[icedtea-web] RFC: fix findbugs communal cloud jnlps

[Omair Majid]

Hi,

It was recently brought to my attention that the jnlps listed at 
http://findbugs.sourceforge.net/index.html (under the section "New") are 
broken, throwing exceptions when trying to run.

The attached fixes the problems.

The first problem was that icedtea-web was trying to ensure that all 
jnlps, including extension jnlps have a main class. I wonder what other 
applications were broken by this check. This patch modifies the check to 
only check for main class when a main class is possible (applets and 
applications).

The second second problem was that (in the extension jnlp file) the jnlp 
element did not contain a codebase attribute. IcedTea-Web tried to add 
this null codebase when merging the jnlp file, causing an exception. The 
patch simply ignores this null.

ChangeLog:

2012-01-05  Omair Majid  <omajid at redhat.com>

   * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
   (initializeResources): Only throw exceptions about the main class not
   being found when the jnlp file can have a main class.
   (addToCodeBaseLoader): Dont try to process null URLs.

Any thoughts or comments?

Thanks,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: findbugs-issues-01.patch
Type: text/x-patch
Size: 1667 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120105/e405d143/findbugs-issues-01.patch