[rfc][icedtea] makefiel part of fix of rhbz 580478
Dr Andrew John Hughes
ahughes at redhat.com
Fri Jan 6 08:04:54 PST 2012
On 10:58 Fri 06 Jan , Omair Majid wrote:
> On 01/06/2012 02:20 AM, Dr Andrew John Hughes wrote:
> >
> > Mostly fine, but you can use configure to do the replacement and it'll automatically handle
> > removal too.
> >
>
> Yes, that's true. But as I mentioned in my review, this approach will
> continue working once we fully support 'make install' (along with custom
> prefixes and destdirs), while the configure approach will not work as well.
>
> We had this discussion a while back when we were trying to add shell
> scripts to serve as launchers in icedtea-web:
> http://thread.gmane.org/gmane.comp.java.openjdk.distro-packaging.devel/12440/focus=12774
>
Yeah, I'm still of the mind that this is the best solution, rather than maintaining our
own. If someone is going to override prefix only via make, they deserve all they get IMHO.
Is there somewhere that actually recommends/documents doing that?
If we really want to support it, it's something that can be looked at on HEAD but
I want the least disruptive change for the release branches and that's the one that uses
configure.
> Cheers,
> Omair
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120106/592d747f/attachment.bin
More information about the distro-pkg-dev
mailing list