/hg/release/icedtea-web-1.1: fix findbugs cloud jnlps

omajid at icedtea.classpath.org omajid at icedtea.classpath.org
Fri Jan 6 23:48:16 PST 2012


changeset f0647c938535 in /hg/release/icedtea-web-1.1
details: http://icedtea.classpath.org/hg/release/icedtea-web-1.1?cmd=changeset;node=f0647c938535
author: Omair Majid <omajid at redhat.com>
date: Sat Jan 07 02:48:05 2012 -0500

	fix findbugs cloud jnlps

	Someone reported that the following JNLP was not starting:
	http://findbugs.cs.umd.edu/cloud/eclipse.jnlp

	The attached fixes the problem, which was that (in the extension
	jnlp file) the jnlp element did not contain a codebase attribute.
	IcedTea-Web tried to add this null codebase when merging the jnlp
	file, causing an exception. The patch simply ignores this null.

	ChangeLog:

	2012-01-07 Omair Majid <omajid at redhat.com>

	 * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
	(addToCodeBaseLoader): Do not try to process null urls.


diffstat:

 ChangeLog                                              |  5 +++++
 netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java |  3 +++
 2 files changed, 8 insertions(+), 0 deletions(-)

diffs (25 lines):

diff -r 9f7d46c3314d -r f0647c938535 ChangeLog
--- a/ChangeLog	Thu Dec 22 16:15:54 2011 -0500
+++ b/ChangeLog	Sat Jan 07 02:48:05 2012 -0500
@@ -1,3 +1,8 @@
+2012-01-07  Omair Majid  <omajid at redhat.com>
+
+	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
+	(addToCodeBaseLoader): Do not try to process null urls.
+
 2011-12-22  Thomas Meyer <thomas at m3y3r.de>
 
 	* plugin/icedteanp/IcedTeaPluginRequestProcessor.cc(sendMember): Use
diff -r 9f7d46c3314d -r f0647c938535 netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
--- a/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java	Thu Dec 22 16:15:54 2011 -0500
+++ b/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java	Sat Jan 07 02:48:05 2012 -0500
@@ -1413,6 +1413,9 @@
      * @throws IllegalArgumentException If the given url is not a path
      */
     private void addToCodeBaseLoader(URL u) {
+        if (u == null) {
+            return;
+        }
 
         // Only paths may be added
         if (!u.getFile().endsWith("/")) {



More information about the distro-pkg-dev mailing list