ARM: Rewrite disassembler to use hsdis

Andrew Hughes ahughes at redhat.com
Mon Jan 23 06:37:16 PST 2012


----- Original Message -----
> 2012-01-20 16:50, Andrew Haley skrev:
> > This patch rewrites the ARM disassembler to use HSDIS rather than
> > call
> > binutils directly.  This removes the build dependency on
> > binutils-devel.  We have to do this because binutils is GPLv3+ and
> > HotSpot is GPLv2 only.  I had to patch HSDIS itself to make it work
> > on
> > ARM; I'll send that patch upstream as well as to IcedTea.
> minor note: doko pointed out that you may compile and link the code
> as is using an old gplv2 licensed binutils-dev.
> 
> > 
> > I also took the opportunity to use the global PrintAssembly
> > setting,
> > but the old T2EE_PRINT_DISASS environment variable stil works if
> > you
> > want to use that.
> > 
> > This is for trunk and branch.
> > 
> > Andrew.
> > 
> > 
> 
> Thank you for bringing the asm port closer to regular hotspot
> implementation.
> I like this patch in large, some minor changes needed, comments
> inline.
> When those are fixed, ok for inclusion into icedtea6 head and 1.11
> release branch.
> 

I'm very wary about introducing Makefile changes into a release branch
at such a late stage.  How does these changes affect other architectures?
Is hsdis part of a regular build?  I see $(CFLAGS) being added, which
has the potential to cause new build breakage if the user can override it.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the distro-pkg-dev mailing list