ARM: Rewrite disassembler to use hsdis

[Andrew Haley]

On 01/23/2012 01:00 PM, Xerxes Rånby wrote:
> 2012-01-20 16:50, Andrew Haley skrev:
>> This patch rewrites the ARM disassembler to use HSDIS rather than call
>> binutils directly.  This removes the build dependency on
>> binutils-devel.  We have to do this because binutils is GPLv3+ and
>> HotSpot is GPLv2 only.  I had to patch HSDIS itself to make it work on
>> ARM; I'll send that patch upstream as well as to IcedTea.
> minor note: doko pointed out that you may compile and link the code as is using an old gplv2 licensed binutils-dev.
> 
> Please add a comment that reflect the magic number 14.
> (11.33.07) xranby: aph: why the magic number 14 ?
> (11.39.20) aph: xranby: cos that's how long the instruction sequence is.   I haven't changed that.

OK.

> Also one level of {} can get removed in this block.

OK.

>> +--- openjdk/hotspot/src/share/tools/hsdis/Makefile	2011-11-14 17:07:33.000000000 -0500
>> ++++ openjdk/hotspot/src/share/tools/hsdis/Makefile	2012-01-20 10:20:32.000000000 -0500
>> +@@ -68,14 +68,18 @@
>> + CONFIGURE_ARGS= --host=$(MINGW) --target=$(MINGW)
>> + else
>> + CPU             = $(shell uname -m)
>> ++ifeq		($(CPU),armv7l)
> 
> What about other arm CPUs?
> How about ifneq           ($(findstring arm,$(CPU)),)

OK.

Andrew.