ARM: Rewrite disassembler to use hsdis

[Andrew Haley]

On 01/23/2012 09:12 PM, Andrew Hughes wrote:
> ----- Original Message -----
>> On 01/23/2012 02:37 PM, Andrew Hughes wrote:
>>>
>>> I'm very wary about introducing Makefile changes into a release
>>> branch
>>> at such a late stage.  How does these changes affect other
>>> architectures?
>>
>> Not at all.
> 
> These chunks would certainly seem to:
> 
> +-CFLAGS		+= -fPIC
> ++CFLAGS		+= -fPIC -g
> 
> +-CPPFLAGS	+= -I$(BINUTILSDIR)/include -I$(BINUTILS)/bfd -I$(TARGET_DIR)/bfd
> ++CPPFLAGS	+= -I$(BINUTILSDIR)/include -I$(BINUTILSDIR)/bfd -I$(TARGET_DIR)/bfd
> 
> +-	if [ ! -f $@ ]; then cd $(TARGET_DIR); make all-opcodes; fi
> ++	if [ ! -f $@ ]; then cd $(TARGET_DIR); make all-opcodes "CFLAGS=$(CFLAGS)"; fi
> 
> As far as I can tell from the hard-to-read patch-within-a-patch, this part isn't within
> an ARM #ifdef.

Sure, but hsdis didn't build at all on any arch, so I'm pretty sure
that other arches aren't affected, unless you count "now builds" as an
affect.

> Have you posted this upstream yet?  I'd be interested to hear Kelly's thoughts.
> 
>>> Is hsdis part of a regular build?
>>
>> No, hsdis is never built in any OpenJDK release.
> 
> Ok, so how it is built?  Just via icedtea-debug?

It's built by the user, if they want disassembly.  It's not part
of any OpenJDK build.  It's not built for some time on IcedTea, as
far as I can tell.

Andrew.