two more tests for icedtea web

Pavel Tisnovsky ptisnovs at redhat.com
Wed Jan 25 07:14:21 PST 2012


Jiri Vanek wrote:
> On 01/24/2012 02:53 PM, Pavel Tisnovsky wrote:
>> Hi Jiri,
>>
>> I'm ok with this update, but I think it would be better to refactor
>> following
>> "magic" numeric constants 1000000l and 30000 into class's final
>> (named) constants
>> (so the change of timeout will be much easier).
>>
>> Pavel
>>
>> Jiri Vanek wrote:
>>> 2011-12-19  Jiri Vanek<jvanek at redhat.com>
>>>
>>>      * tests/jnlp_tests/simple/AppletTest/ : test for loading applets by
>>> jnlp file
>>>
>>> 2011-12-19  Jiri Vanek<jvanek at redhat.com>
>>>
>>>      Added test for -Xnofork option
>>>      *
>>> tests/jnlp_tests/simple/deadlocktest/resources/deadlocktest_1.jnlp: new
>>> file
>>>      By specifying new max heap size, should invoke jvm to fork when
>>> launched
>>>      * tests/jnlp_tests/simple/deadlocktest/srcs/DeadlockTest.java:
>>>      improved indentation, added debug output that main method was
>>> lunched
>>>      *
>>> tests/jnlp_tests/simple/deadlocktest/testcases/DeadLockTestTest.java:
>>>      small refactoring, add lunching  of deadlocktest_1.jnlp with and
>>>      without -Xnofork, and counting java instances during runtime
>>>      *
>>> tests/netx/jnlp_testsengine/net/sourceforge/jnlp/ServerAccess.java
>>>      (ThreadedProcess.run) fixed situation, when process ended, but
>>> not all
>>>      the output was read by its stdout/stderr readers
>>>      (ContentReader.run) enabled exception printing to stderr.
>>>
>>> Regards J.
>>>
>>
> 
> Tyvm for review! I have isolated the constants. Ok for head?
> 
> J.

I'm ok with this change. Thank you.

> 
> 
> 
> 2012-01-25  Jiri Vanek  <jvanek at redhat.com>
> 
>     Added test for -Xnofork option
>     *
> tests/jnlp_tests/simple/deadlocktest/resources/deadlocktest_1.jnlp: new
> file
>     By specifying new max heap size, should invoke jvm to fork when
> launched
>     * tests/jnlp_tests/simple/deadlocktest/srcs/DeadlockTest.java:
>     improved indentation, added debug output that main method was lunched
>     * tests/jnlp_tests/simple/deadlocktest/testcases/DeadLockTestTest.java:
>     small refactoring, add lunching  of deadlocktest_1.jnlp with and
>     without -Xnofork, and counting java instances during runtime
>     * tests/netx/jnlp_testsengine/net/sourceforge/jnlp/ServerAccess.java
>     (ThreadedProcess.run) fixed situation, when process ended, but not all
>     the output was read by its stdout/stderr readers
>     (ContentReader.run) enabled exception printing to stderr.
>     * tests/jnlp_tests/simple/AppletTest/ : test for loading applets by
> jnlp file
> 




More information about the distro-pkg-dev mailing list