[rfc] [icedtea-web] fix for PR811

Jiri Vanek jvanek at redhat.com
Tue Jul 3 04:55:21 PDT 2012


On 07/03/2012 01:21 PM, Pavel Tisnovsky wrote:
> Jiri Vanek wrote:
>> On 05/18/2012 04:30 PM, Jiri Vanek wrote:
>>> On 05/18/2012 03:34 PM, Pavel Tisnovsky wrote:
>>>> Hi Jiri,
>>>>
>>> Thanx! Pushed to head.
>>>> the icedtea-web patch (w/o tests):
>>>> it think it's ok, but please fix this typo in a comment:
>>>>
>>>> sielnt ->  silent
>>> fixed
>>>>
>>>> Personally I'd rather to rewrite notNullUrlEquals() method not to use
>>>> if-then-else blocks at all (you can directly return the return value of
>>>> the expression) but it's just a personal feeling ;-)
>>>>
>>>>
>>>> the test patch:
>>>> I'm not sure if following lines are ok in case of JDK7:
>>>>
>>>> +        System.out.println("connecting NotOnly spaces can kill
>>>> ěščřž too.jnlp request");
>>>> +        System.err.println("connecting NotOnly spaces can kill
>>>> ěščřž too.jnlp request");
>>>>
>>>>
>>> No worries - I have checked it on jdk7.
>>>> Cheers,
>>>> Pavel
>>>>
>>>>
>>
>>
>> I would like to backport this to 1.2. Soemthing against?
>

Thanx,.Backported.

> Hi Jiri,
>
> I'm ok with backporting this change to 1.2 too. Are we planning to make a new release
> of 1.2?

hmm. interesting idea.. couple of fixes have been already introduced.. f15+16+17 maybe deserves one :)

>
> Cheers,
> Pavel
>>
>> J.
>





More information about the distro-pkg-dev mailing list