[fyi][icedtea-web]Refactoring of reproducers as agreed in April

[Jiri Vanek]

...
>>> # HG changeset patch
>>> # User Jiri Vanek <jvanek at redhat.com>
>>> # Date 1340971958 -7200
>>> # Node ID c913c1fd1138c833df13146da42c9d0a3512d7fd
>>> # Parent  5b088a10b659082df3abe9629cc8dae9cc453dd3
>>> Renamed make variables to correspond with new directory structure
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -12,19 +12,21 @@
>>>   export TESTS_DIR=$(abs_top_builddir)/tests.build
>>>
>>>   export NETX_UNIT_TEST_SRCDIR=$(TESTS_SRCDIR)/netx/unit
>>> -export NETX_UNIT_TEST_DIR=$(TESTS_DIR)/netx/unit
>>> +export NETX_TEST_DIR=$(TESTS_DIR)/netx
>>> +export NETX_UNIT_TEST_DIR=$(NETX_TEST_DIR)/unit
>>>
>>>   export JUNIT_RUNNER_DIR=$(TESTS_DIR)/junit-runner
>>>   export JUNIT_RUNNER_SRCDIR=$(TESTS_SRCDIR)/junit-runner
>>>
>>>
>>> -export JNLP_TESTS_ENGINE_SRCDIR=$(TESTS_SRCDIR)/test-extensions
>>> -export JNLP_TESTS_ENGINE_TESTS_SRCDIR=$(TESTS_SRCDIR)/test-extensions-tests
>>> -export JNLP_TESTS_SRCDIR=$(TESTS_SRCDIR)/reproducers
>>> -export JNLP_TESTS_ENGINE_DIR=$(TESTS_DIR)/jnlp_testsengine
>>> -export JNLP_TESTS_ENGINE_TESTS_DIR=$(TESTS_DIR)/netx/jnlp_testsengine_tests
>>> -export JNLP_TESTS_SERVER_DEPLOYDIR=$(TESTS_DIR)/jnlp_test_server
>>> -export JNLP_TESTS_DIR=$(TESTS_DIR)/jnlp_tests
>>> +export TEST_EXTENSIONS_SRCDIR=$(TESTS_SRCDIR)/test-extensions
>>> +export TEST_EXTENSIONS_TESTS_SRCDIR=$(TESTS_SRCDIR)/test-extensions-tests
>>> +export REPRODUCERS_TESTS_SRCDIR=$(TESTS_SRCDIR)/reproducers
>>> +export TEST_EXTENSIONS_DIR=$(TESTS_DIR)/test-extensions
>>> +export TEST_EXTENSIONS_COMPATIBILITY_SYMLINK=$(TESTS_DIR)/netx/jnlp_testsengine
>>> +export TEST_EXTENSIONS_TESTS_DIR=$(TESTS_DIR)/test-extensions-tests
>>> +export REPRODUCERS_TESTS_SERVER_DEPLOYDIR=$(TESTS_DIR)/reproducers_test_server_deploydir
>>
>> I think just REPRODUCERS_DEPLOYDIR would be sufficient, but it's up to you.
>>
>> Looks fine to me.
>
> It looks like you are fine also with renaming. I will push immediately after confirmation. And test
> again on my said :)
>
> Thank you very much for cooperation on this painful refactoring!
>
>

Hi. Updated renaming patch. Please chheck that I did not screw any renaming :-/

  J.
>
> updated todo:
>
>
> * investigate GPLv2 x  GPLv2 + Classpath exception for TinyHttpdImpl inspiration. I would suggest to
> email author....
> * change package inside test-extensions(-tests) - net.sourceforge.jnlp "namespace"  to something
> like org.classpath.icedteaweb.tests ot  org.foo.bar ;)
> * rename charReaded and  lineReaded to charRead/lineRead
> * made Browsers enum members UPPERCASE
> * XslowX replace by something else (imho not annotation, because then you will miss possibility to
> use it without test method, nor environment variable because you can not reset it for running
> process. Maybe some flag file?)
> * EMMA filtration in process result replace by some little bit more clever middlemen
> * reconsider ProcessBuilder
> * investigate on "Thread.sleep(500); //this is giving to fast done proecesses's e/o readers time to
> read all. I would like to know better solution :-/ "
> * fix unnecessary  NETX_DIR dependences


-------------- next part --------------
A non-text attachment was scrubbed...
Name: renamimgOfTestVariables.diff
Type: text/x-patch
Size: 22148 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120703/f9074c45/renamimgOfTestVariables.diff