RFC: fix path to test jre in tapset test

[Jon VanAlten]

----- Original Message -----
> From: "Mark Wielaard" <mjw at redhat.com>
> To: "Omair Majid" <omajid at redhat.com>
> Cc: "IcedTea" <distro-pkg-dev at openjdk.java.net>
> Sent: Wednesday, July 4, 2012 5:01:12 PM
> Subject: Re: RFC: fix path to test jre in tapset test
> 
> On Thu, Jun 28, 2012 at 11:39:11AM -0400, Omair Majid wrote:
> > On 06/27/2012 07:25 PM, Andrew Hughes wrote:
> > > ----- Original Message -----
> > >> On Tue, 2012-06-26 at 17:46 -0400, Omair Majid wrote:
> > >>> There is a minor typo in the tapset test script. It assumes
> > >>> ix86
> > >>> systems have a jre arch directory of "i586", which contradicts
> > >>> what acinclude.m4 says:
> > 
> > > You missed 8, Omair :-)
> > 
> > Thanks, I had forgotten about that. But it turns out that the
> > test/tapset directory doesnt exist in 8 :( Were the tapset tests
> > ever
> > added to 8?
> 
> I assumed 8 branched from 7 after the tapset tests were added,
> but it seems I am mistaken and 8 was created (long) before that.
>  
> > Mark, what are the plans for the tapset tests? I see that you have
> > proposed the dtrace macro changes for inclusion in jdk8. Do you
> > intend
> > to propose upstream to include the tapsets too? What about the
> > tapset
> > tests? If these aren't going upstream, then we probably want to add
> > them
> > to icedtea8.
> 
> I hadn't really thought about it and I don't know if Jon wants to
> push
> them. But given that even a small patch to tweak some defines in an
> existing hotspot file takes months I am afraid to think how long new
> infrastructure patch might take (the tapset testsuite relies on
> perl).
> 

The tests of course depend also on the tapsets themselves ;)

I would be ok with pushing this upstream.  But also worried about the
effort required.  As far as the perl requirement, at one point I had
a bash version.  Maybe I can still find it?  (and then if I can maybe
it still works!)

Mark, if you plan to eventually upstream the tapsets, do you think it
would be easier to upstream the tests with a bash harness rather than
perl?

cheers,
jon