[RFC][icedtea-web]: Minor clean up of slowdown code
Adam Domurad
adomurad at redhat.com
Mon Jul 9 11:46:13 PDT 2012
On Mon, 2012-07-09 at 14:27 -0400, Saad Mohammad wrote:
> Hello,
>
> The patch attached removes the check for the main-class name from the
> for loop; it is now checked once before entering the loop. Thanks Adam
> for pointing this out. :)
>
> Changelog:
> 2012-07-09 Saad Mohammad <smohammad at redhat.com>
>
> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
> (initializeExtensions): Removes potential slowdown; main-class name is
> checked once outside of loop.
>
OK for HEAD.
Just a nit - in the ChangeLog I wouldn't say 'Removes potential
slowdown'. This implies that something could be slower for the end user.
Just wanted to clarify that I didn't point this out for performance
reasons :) The performance gain here is virtually impossible to measure.
The main improvement here is simply, moving code that doesn't belong in
a loop. This helps readability and is a more logical design.
More information about the distro-pkg-dev
mailing list