[rfc][icedtea-web] Introduce LaunchDesc interface for AppletDesc, ApplicationDesc & InstallerDesc

[Jiri Vanek]

On 06/25/2012 05:11 PM, Adam Domurad wrote:
> Hi. This patch addresses the issue that JNLPFile#launchType has a
> non-descript type of 'Object'. This introduces an appropriate type,
> LaunchDesc.
>
> One open question I have is, I noticed two pieces of code in
> JNLPClassLoader that checked specifically if the LaunchDesc was an
> AppletDesc or an ApplicationDesc. How should these be handled in the
> case of an InstallerDesc ? In the new patch, it simply tests if the
> LaunchDesc is not null. Should InstallerDesc not be handled in
> JNLPClassLoader#checkForMain as before ?
>
> ChangeLog:
> 2012-06-25  Adam Domurad<adomurad at redhat.com>
>
> 	Refactor JNLPFile#launchType into its own interface type (as opposed to
> 	Object), LaunchDesc.
> 	* netx/net/sourceforge/jnlp/AppletDesc.java: Add override annotation to
> 	getMainClass().
> 	* netx/net/sourceforge/jnlp/ApplicationDesc.java: Same as above
> 	* netx/net/sourceforge/jnlp/InstallerDesc.java: Same as above
> 	* netx/net/sourceforge/jnlp/JNLPFile.java: Make launchType a
> 	LaunchDesc object. Update getLaunchInfo() accordingly.
> 	* netx/net/sourceforge/jnlp/LaunchDesc.java: New launch description.
> 	* netx/net/sourceforge/jnlp/Parser.java
> 	(getLauncher): Return type changed to LaunchDesc
> 	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Replace
> 	occurences of instanceof with respect to launchType.
>
>
ok for head and 1.3

J.