[RFC][icedtea-web]: PR1049 fix - extension jnlp with empty jars
Saad Mohammad
smohammad at redhat.com
Mon Jul 23 15:47:30 PDT 2012
Hi Adam,
Sorry for multiple emails but it seems like the patch command does not like
empty files too much :(. The previous patch was not creating the new empty file
because it had no content
(tests/reproducers/signed/EmptySignedJar/srcs/META-INF/emptyFile).
I have fixed this problem in the updated reproducer patch attached. This patch
contains two filename changes and an added test.
I have attached the PRO1049 fix in my previous email with some comments. Please
let me know if you run into any problems. Sorry again for all the trouble.
Thanks.
Changelog:
2012-07-23 Saad Mohammad <smohammad at redhat.com>
* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java (initializeResources):
Removes the display of the security dialog for loaders with only empty jars.
* netx/net/sourceforge/jnlp/tools/JarCertVerifier.java:
(JarCertVerifier): Tracks whether all jars verified are empty jars.
(hasAllEmptyJars): Returns true if all jars verified are empty jars.
(verifyJars): Checks whether signable entries and certificates are found and
decides if all jars are empty jars.
(isFullySignedByASingleCert): If all jars are emptyJars, returns true.
*
tests/reproducers/signed/EmptySignedJar/resources/EmptySignedJarInLaunchingJnlp.jnlp:
Launching jnlp with the resource of an empty jar and an extension jnlp
containing the main jar.
*
tests/reproducers/signed/EmptySignedJar/resources/EmptySignedJarInExtensionJnlp.jnlp:
Launching jnlp with the resource of the main jar and an extension jnlp
containing the empty jar.
* tests/reproducers/signed/EmptySignedJar/resources/EmptySignedJarExtension.jnlp:
Extension jnlp containing only an empty jar.
* tests/reproducers/signed/EmptySignedJar/srcs/META-INF/emptyFile:
Empty file within META-INF; required to create EmptySignedJar.jar
by the test engine.
* tests/reproducers/signed/EmptySignedJar/testcases/EmptySignedJarTest.java:
Testcase that tests jnlp files with empty jars.
* tests/reproducers/signed/SignedJarResource/resources/SignedJarResource.jnlp:
Launches SignedJarResource class directly.
--
Cheers,
Saad Mohammad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: changelogEntry-3.patch
Type: text/x-patch
Size: 1744 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120723/41c62235/changelogEntry-3.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reproducers_3.patch
Type: text/x-patch
Size: 15264 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120723/41c62235/reproducers_3.patch
More information about the distro-pkg-dev
mailing list