/hg/icedtea-web: CVE-2012-3422, RH840592: Potential read from an...

[dbhole at icedtea.classpath.org]

changeset 504ad6ea95fa in /hg/icedtea-web
details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=504ad6ea95fa
author: Deepak Bhole <dbhole at redhat.com>
date: Tue Jul 24 11:44:50 2012 -0400

	CVE-2012-3422, RH840592: Potential read from an uninitialized memory location

	Updated NEWS file with entry for CVE-2012-3423


diffstat:

 ChangeLog                           |  10 ++++++++++
 NEWS                                |   5 +++++
 plugin/icedteanp/IcedTeaNPPlugin.cc |  10 ++++++++++
 3 files changed, 25 insertions(+), 0 deletions(-)

diffs (59 lines):

diff -r 09198dc413b5 -r 504ad6ea95fa ChangeLog
--- a/ChangeLog	Tue Jul 31 09:55:12 2012 -0400
+++ b/ChangeLog	Tue Jul 24 11:44:50 2012 -0400
@@ -1,3 +1,13 @@
+2012-07-24  Adam Domurad  <adomurad at redhat.com>
+
+	CVE-2012-3422, RH840592: Potential read from an uninitialized
+	memory location.
+	* plugin/icedteanp/IcedTeaNPPlugin.cc
+	(get_cookie_info): Only attempt to perform this operation if there is a
+	valid plugin instance
+	(get_proxy_info): Only attempt to perform this operation if there is a
+	valid plugin instance
+
 2012-07-31  Danesh Dadachanji  <ddadacha at redhat.com>
 
 	* Makefile.am: Fix call to keytool that is missing its absolute path.
diff -r 09198dc413b5 -r 504ad6ea95fa NEWS
--- a/NEWS	Tue Jul 31 09:55:12 2012 -0400
+++ b/NEWS	Tue Jul 24 11:44:50 2012 -0400
@@ -8,6 +8,11 @@
 
 CVE-XXXX-YYYY: http://www.cve.mitre.org/cgi-bin/cvename.cgi?name=XXXX-YYYY
 
+New in release 1.4 (2012-XX-XX):
+* Security updates
+  - CVE-2012-3422, RH840592: Potential read from an uninitialized memory location
+  - CVE-2012-3423, RH841345: Incorrect handling of not 0-terminated strings
+
 New in release 1.3 (2012-XX-XX):
 * NetX
   - PR898: signed applications with big jnlp-file doesn't start (webstart affect like "frozen")
diff -r 09198dc413b5 -r 504ad6ea95fa plugin/icedteanp/IcedTeaNPPlugin.cc
--- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Tue Jul 31 09:55:12 2012 -0400
+++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Tue Jul 24 11:44:50 2012 -0400
@@ -925,6 +925,11 @@
 NPError
 get_cookie_info(const char* siteAddr, char** cookieString, uint32_t* len)
 {
+  // Only attempt to perform this operation if there is a valid plugin instance
+  if (g_hash_table_size(instance_to_id_map) <= 0)
+  {
+    return NPERR_GENERIC_ERROR;
+  }
 #if MOZILLA_VERSION_COLLAPSED < 1090100
   nsresult rv;
   nsCOMPtr<nsIScriptSecurityManager> sec_man =
@@ -1330,6 +1335,11 @@
 NPError
 get_proxy_info(const char* siteAddr, char** proxy, uint32_t* len)
 {
+  // Only attempt to perform this operation if there is a valid plugin instance
+  if (g_hash_table_size(instance_to_id_map) <= 0)
+  {
+	  return NPERR_GENERIC_ERROR;
+  }
 #if MOZILLA_VERSION_COLLAPSED < 1090100
   nsresult rv;