[rfc][icedtea-web] Tiny patch to make last param in applet tag take effect, was first

[Jiri Vanek]

On 05/31/2012 09:31 PM, Adam Domurad wrote:
> Gah. Always forget to group-reply.
>
> Here are two reproducers, one for checking that the final param is taken
> in a .jnlp file (current behaviour), and one for checking that the final
> param is taken in a .html file (post-patch behaviour).
>
> ChangeLog:
> 2012-05-31  Adam Domurad<adomurad at redhat.com>
> 	
> 	Reproducers to ensure that equivalent parameters take the value of the
> 	second parameter tag to occur.
> 	*
> tests/jnlp_tests/simple/AppletTakesLastParam/resources/appletTakesLastParam.html:
> 	New, tests parameter duplication in applet-tags.
> 	*
> tests/jnlp_tests/simple/AppletTakesLastParam/resources/appletTakesLastParam.jnlp:
> 	New, tests parameter duplication in jnlp files.
> 	*
> tests/jnlp_tests/simple/AppletTakesLastParam/srcs/AppletTakesLastParam.java:
> 	New, reads a duplicated parameter, 'param'.
> 	*
> tests/jnlp_tests/simple/AppletTakesLastParam/testcases/AppletTakesLastParamTests.java:
> 	New, drives test for duplicated param in .jnlp and .html files.
>
> Cheers,
> Adam

Hi! Thanx for reproducer. Only two tiny things, After fixed you can go ahead and push!
 > diff --git a/netx-dist-tests-whitelist b/netx-dist-tests-whitelist
 > --- a/netx-dist-tests-whitelist
 > +++ b/netx-dist-tests-whitelist
 > @@ -1,1 +1,1 @@
 > -.*
 > +AppletTakesLastParam

Definitely remove this file from changeset;)  (I believe it was unintentionally added, so please be careful with unrelated changes.)


+
+    @Test
+    public void AppletInFirefoxTest() throws Exception {
+        ServerAccess.ProcessResult pr = server.executeBrowser("/appletTakesLastParam.html");
+        pr.process.destroy();
+        evaluateApplet(pr);
+        Assert.assertTrue(pr.wasTerminated);
+    }
+}


The        "pr.process.destroy()" Is no longer necessary[1]. If you have copy-pasted it form somewhere, please can you remove it also form this source? (But ensure Thet I'm not lying ;)

[1] http://icedtea.classpath.org/hg/icedtea-web/rev/16a8b7bfee7d?revcount=120

Thanx again for tests!

J.
>
> On Thu, 2012-05-31 at 08:47 +0200, Jiri Vanek wrote:
>> On 05/30/2012 11:14 PM, Omair Majid wrote:
>>> On 05/30/2012 05:04 PM, Omair Majid wrote:
>>>> On 05/30/2012 04:57 PM, Adam Domurad wrote:
>>>>> Tiny patch to make handling of applet tags more like Oracle's plugin.
>>>>> This makes our plugin take into account the last<param ...>   tag with
>>>>> the same 'name'. It was taking into account the first such tag.
>>>>>
>>>>> 2012-05-30  Adam Domurad<adomurad at redhat.com>
>>>>> 	
>>>>> 	* plugin/icedteanp/java/sun/applet/PluginAppletViewer.java:
>>>>> 	(parse) Small change to have last<param name=... value=...>   tag to
>>>>> 	take effect.
>>>>
>>>
>>> Btw, I would strongly encourage you to write a reproducer (or unit) test
>>> for this.
>>>
>>> Cheers,
>>> Omair
>>
>> Definitely. Please provide reproducer before push of this changeset.
>>
>> Thanx in advance, J.
>
>
>
>