[rfc][icedtea-web] known to fail annotation

[Jiri Vanek]

On 06/05/2012 02:51 PM, Jiri Vanek wrote:
> On 06/04/2012 09:53 PM, Omair Majid wrote:
>> On 05/23/2012 10:59 AM, Jiri Vanek wrote:
>>> On 05/22/2012 07:30 PM, Omair Majid wrote:
>>>> On 05/22/2012 08:56 AM, Jiri Vanek wrote:
>>>>> As agreed on IRC, Percentage removed. What do you think now?
> ...snip ..
>>> diff -r 1088b2dffe49 tests/junit-runner/LessVerboseTextListener.java
>>> --- a/tests/junit-runner/LessVerboseTextListener.java Tue May 22 12:08:17 2012 +0200
>>> +++ b/tests/junit-runner/LessVerboseTextListener.java Wed May 23 16:41:21 2012 +0200
>>
>>> @@ -45,7 +60,56 @@
>>> int passed = result.getRunCount() - result.getFailureCount() - result.getIgnoreCount();
>>> int failed = result.getFailureCount();
>>> int ignored = result.getIgnoreCount();
>>> - writer.println("Test results: passed: " + passed + "; failed: " + failed + "; ignored: " + ignored);
>>> + writer.println("Test known to fail ("+totalK2F+"): passed: " + passedK2F + "; failed: " + failedK2F + "; ignored: " + ignoredK2F);
>>> + writer.println("Test results ("+result.getRunCount()+"): passed: " + passed + "; failed: " + failed + "; ignored: " + ignored);
>>> + }
>
>
> Do you mind to have total/totalKnownToFail line here? So the three lines will be
>
> total
> know to fail sumary
> unchanged last line as you wanted
>
> =~
>
> writer.println("Total tests "+result.getRunCount()+"/ known to fail tests "+totalK2F);
> writer.println("Test known to fail: passed: " + passedK2F + "; failed: " + failedK2F + "; ignored: " + ignoredK2F);
> writer.println("Test results: passed: " + passed + "; failed: " + failed + "; ignored: " + ignored);
>
>>
>> Please leave the original line ("Test results: passed:"..) unchanged
>> (unless you are going to combine the two lines).
>>
>> Otherwise, this looks fine to me.
> Is this approve? :D
>>
>> Cheers,
>> Omair
>

example of output:

....
Passed: net.sourceforge.jnlp.ParserMalformedXml.testMissingXmlDecleration
FAILED: testMalformedArguments(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML document syntax.
  - This test is known to fail
FAILED: testTagNotClosed(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML document syntax.
  - This test is known to fail
FAILED: testUnquotedAttributes(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML document syntax.
  - This test is known to fail
Passed: net.sourceforge.jnlp.util.PropertiesFileTest.testReloadAfterStore
Passed: net.sourceforge.jnlp.util.ImageResourcesTest.testApplicationImages
Passed: net.sourceforge.jnlp.util.replacements.BASE64EncoderTest.testEmbededBase64Encoder
Passed: net.sourceforge.jnlp.util.replacements.BASE64EncoderTest.testEmbededBase64EncoderAgainstSunOne
Total tests run: 75; From  those : 8 known to fail
Test known to fail: passed: 0; failed: 8; ignored: 0
Test results: passed: 66; failed: 9; ignored: 0

(do not bother with the one-more failing test)


2012-05-14  Jiri Vanek  <jvanek at redhat.com>

	* tests/netx/jnlp_testsengine/net/sourceforge/jnlp/annotations/KnownToFail.java
	New file. Annotation for marking failing tests.
	* tests/report-styles/jreport.xsl:
	* tests/junit-runner/LessVerboseTextListener.java:
	* tests/junit-runner/JunitLikeXmlOutputListener.java:  Added counting
	and printing of @KnownToFail annotations if presented.
	* tests/jnlp_tests/simple/Spaces can be everywhere/testcases/SpacesCanBeEverywhereTests.java:
	(SpacesCanBeEverywhereRemoteTests1) (SpacesCanBeEverywhereRemoteTests2)
	(SpacesCanBeEverywhereRemoteTests3)
	* tests/netx/unit/net/sourceforge/jnlp/JNLPMatcherTest.java: (testTemplateCDATA)
	(testApplicationCDATA)
	* tests/netx/unit/net/sourceforge/jnlp/ParserCornerCases.java:
	(testCDataFirstChild) (testCDataSecondChild) (testCommentInAttributes)
	* tests/netx/unit/net/sourceforge/jnlp/ParserMalformedXml.java:
	(testMalformedArguments) (testTagNotClosed) (testUnquotedAttributes)
	marked as KnownToFail



-------------- next part --------------
A non-text attachment was scrubbed...
Name: knownToFail-final.diff
Type: text/x-patch
Size: 26945 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120605/2db6a4cc/knownToFail-final.diff