[RFC][icedtea-web] Fix for PR855: AppletStub getDocumentBase() doesn't return full URL
Jiri Vanek
jvanek at redhat.com
Thu Jun 14 01:23:15 PDT 2012
On 06/14/2012 12:02 AM, Danesh Dadachanji wrote:
>
>
> On 13/06/12 10:13 AM, Jiri Vanek wrote:
>> On 06/08/2012 06:23 PM, Danesh Dadachanji wrote:
>>> On 07/06/12 04:32 PM, Danesh Dadachanji wrote:
>>>> On 05/06/12 08:15 AM, Jiri Vanek wrote:
>>>>> On 06/04/2012 11:53 PM, Danesh Dadachanji wrote:
>>>>>> On 18/05/12 05:15 AM, Jiri Vanek wrote:
>>>>>>> On 05/17/2012 11:16 PM, Danesh Dadachanji wrote:
>>>>>>>>
>>>>>>>> On 16/04/12 01:18 PM, Deepak Bhole wrote:
>> ...snip...
>>>>
>>>
>>>
>>> Realized I had not added a NEWS entry, patch updated.
>>>
>>
>>
>> Thanx for tests. They are passed, failed, failed before fix - assuming the nature of fox I think it
>> is correct (correct me if I'm wrong!)
>
> Yes, sorry for not pointing this out! I updated the @Bug annotation to only point to the browser tests since technically the bug is only relevant for those.
>
>> Also according to the nature of patch I guess there is no need to test application+jnlp behaviour. If it should be tested please
>> prepare another changeset of tests for this (you can reuse your applet)
>>
>> four errors in code bellow please. After fixing, ensure all reproducers flow through testsuites and push.
>>
>
> All fixed. =) You also reviewed an older patch, would you mind double checking the newest one and okaying for HEAD again? Thanks a lot for all the reviews!
>
> Cheers,
> Danesh
yy. Go on and push.
J.
More information about the distro-pkg-dev
mailing list