/hg/icedtea-web: Refactored two loops to for-each loops in JCV
adomurad at icedtea.classpath.org
adomurad at icedtea.classpath.org
Tue Jun 19 07:26:53 PDT 2012
changeset 4a89a9c1a662 in /hg/icedtea-web
details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=4a89a9c1a662
author: Adam Domurad <adomurad at redhat.com>
date: Tue Jun 19 10:26:44 2012 -0400
Refactored two loops to for-each loops in JCV
diffstat:
ChangeLog | 5 +++++
netx/net/sourceforge/jnlp/tools/JarCertVerifier.java | 12 +++---------
2 files changed, 8 insertions(+), 9 deletions(-)
diffs (60 lines):
diff -r 8869ef29f987 -r 4a89a9c1a662 ChangeLog
--- a/ChangeLog Tue Jun 19 15:40:28 2012 +0200
+++ b/ChangeLog Tue Jun 19 10:26:44 2012 -0400
@@ -1,3 +1,8 @@
+2012-06-18 Adam Domurad <adomurad at redhat.com>
+
+ * netx/net/sourceforge/jnlp/tools/JarCertVerifier.java
+ (verifyJar): two for loops made into for-each loops
+
2012-06-19 Jiri Vanek <jvanek at redhat.com>
various test for browser engine
diff -r 8869ef29f987 -r 4a89a9c1a662 netx/net/sourceforge/jnlp/tools/JarCertVerifier.java
--- a/netx/net/sourceforge/jnlp/tools/JarCertVerifier.java Tue Jun 19 15:40:28 2012 +0200
+++ b/netx/net/sourceforge/jnlp/tools/JarCertVerifier.java Tue Jun 19 10:26:44 2012 -0400
@@ -183,9 +183,7 @@
verifiedJars = new ArrayList<String>();
unverifiedJars = new ArrayList<String>();
- for (int i = 0; i < jars.size(); i++) {
-
- JARDesc jar = jars.get(i);
+ for (JARDesc jar : jars) {
try {
@@ -242,10 +240,9 @@
Vector<JarEntry> entriesVec = new Vector<JarEntry>();
byte[] buffer = new byte[8192];
- JarEntry je;
Enumeration<JarEntry> entries = jarFile.entries();
while (entries.hasMoreElements()) {
- je = entries.nextElement();
+ JarEntry je = entries.nextElement();
entriesVec.addElement(je);
InputStream is = jarFile.getInputStream(je);
@@ -265,12 +262,10 @@
if (jarFile.getManifest() != null) {
if (verbose)
System.out.println();
- Enumeration<JarEntry> e = entriesVec.elements();
long now = System.currentTimeMillis();
- while (e.hasMoreElements()) {
- je = e.nextElement();
+ for (JarEntry je : entriesVec) {
String name = je.getName();
CodeSigner[] signers = je.getCodeSigners();
boolean isSigned = (signers != null);
@@ -352,7 +347,6 @@
addToDetails(R("SNotYetValidCert"));
}
}
-
} catch (Exception e) {
e.printStackTrace();
throw e;
More information about the distro-pkg-dev
mailing list