[rfc] [icedtea-web] reproducers with custom makefile

[Danesh Dadachanji]

On 25/06/12 02:36 PM, Jiri Vanek wrote:
> @@ -686,6 +704,31 @@
>   endif
>   	touch $@
>
> +stamps/process-custom-reproducers.stamp: stamps/junit-jnlp-dist-dirs stamps/netx-dist-tests-import-cert-to-public \
> + stamps/netx-dist-tests-compile.stamp stamps/netx-dist-tests-compile-testcases.stamp $(JUNIT_RUNNER_JAR) stamps/netx-dist-tests-copy-resources.stamp\
> + $(TESTS_DIR)/$(REPORT_STYLES_DIRNAME) $(REPRODUCERS_CLASS_NAMES)
> +	. $(abs_top_srcdir)/NEW_LINE_IFS ; \
> +	customReproducers=(`cat $(abs_top_builddir)/junit-jnlp-dist-custom.txt `); \
> +	IFS="$$IFS_BACKUP" ; \
> +	for dir in "$${customReproducers[@]}" ; do \
> +	  pushd $(JNLP_TESTS_SRCDIR)/$(CUSTOM_REPRODUCERS)/$$dir/srcs; \
> +	  $(MAKE) prepare-reproducer ; \
> +	  popd ; \
> +	done ; \
> +	mkdir -p stamps && \
> +	touch $@
> +
> +clean-custom-reproducers: junit-jnlp-dist-custom.txt
> +	. $(abs_top_srcdir)/NEW_LINE_IFS ; \
> +	customReproducers=(`cat $(abs_top_builddir)/junit-jnlp-dist-custom.txt `); \
> +	IFS="$$IFS_BACKUP" ; \
> +	for dir in "$${customReproducers[@]}" ; do \
> +	  pushd $(JNLP_TESTS_SRCDIR)/custom/$$dir/srcs; \
> +	  $(MAKE) clean-reproducer ; \
> +	  popd ; \
> +	done ; \
> +	rm -f stamps/process-custom-reproducers.stamp
> +

The chunk above does not work when you have a different build dir from src dir. I think JNLP_TESTS_SRCDIR is incorrect here but I'm not 
100% sure. Could you please fix this?

Partial make run-netx-dist-tests log:

. /home/ddadacha/icedtea-web/build/../NEW_LINE_IFS ; \
customReproducers=(`cat /home/ddadacha/icedtea-web/build/junit-jnlp-dist-custom.txt `); \
IFS="$IFS_BACKUP" ; \
for dir in "${customReproducers[@]}" ; do \
   pushd /home/ddadacha/icedtea-web/build/../tests/jnlp_tests/custom/$dir/srcs; \
   make prepare-reproducer ; \
   popd ; \
done ; \
mkdir -p stamps && \
touch stamps/process-custom-reproducers.stamp
/bin/sh: line 4: pushd: /home/ddadacha/icedtea-web/build/../tests/jnlp_tests/custom/junit-jnlp-dist-simple.txt/srcs: No such file or 
directory
make[1]: Entering directory `/home/ddadacha/icedtea-web/build'
make[1]: *** No rule to make target `prepare-reproducer'.  Stop.
make[1]: Leaving directory `/home/ddadacha/icedtea-web/build'
/bin/sh: line 6: popd: directory stack empty
<many of the same errors>