[RFC][icedtea-web]: Fix for PR1040, PR1041, PR1042 w/ reproducers

[Saad Mohammad]

On 06/26/2012 11:55 AM, Adam Domurad wrote:
> Thanks for the update. I think the new changeset is clearer in intent.
>
> JNLPClassLoader is growing quite large, but that's neither here nor
> there. It might be good to break down its functionality sometime in the
> future (I have two patches waiting review, for example, that add to its
> length somewhat).

Thanks again Adam for looking over my patch. I updated the patch with your 
suggestions. Also thanks for the tip with using operators, I'll try to use them 
more in future code. :)

I have attached the new Changelog, Bug fix patch. The reproducer has not changed 
from previous email but still needs review.

ChangeLog:

2012-06-26  Saad Mohammad  <smohammad at redhat.com>

	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
	(JNLPClassLoader): New constructor that accepts a parameter containing
	the main class name
	(initializeJNLPClassLoader): Initializes the JNLPClassLoader
	(getInstance): Accepts mainName as parameter to override application's
	main class name
	(initializeExtensions): Passes in the name of the application's main class
	when creating a new JNLPClassLoader instance.
	(initializeResources): If the loader owns no jars, it will consider
	itself as signed if all of its extension loaders are signed. Also, if the
	extension jars has the main class, it will assign foundMainJar to true.
	(initializeResources): If the main class was not found, check if it was
	found within the extension jars.
	(checkForMain): Uses the overwritten main class name (if assigned) when
	searching for the main within the jars.
	(hasMainJar): Returns true if this loader holds the main jar.
	(hasMainInExtensions): Returns true if extension loaders have the main jar
	* tests/jnlp_tests/signed/ExtensionJnlp/resources/ExtensionJnlp1.jnlp:
	* tests/jnlp_tests/signed/ExtensionJnlp/resources/ExtensionJnlp2.jnlp:
	* tests/jnlp_tests/signed/ExtensionJnlp/resources/ExtensionJnlp3.jnlp:
	* tests/jnlp_tests/signed/ExtensionJnlp/resources/ExtensionJnlp4.jnlp:
	Launching jnlp that launches SignedJarResource class.
	* tests/jnlp_tests/signed/ExtensionJnlp/resources/ExtensionJnlp5.jnlp:
	Launching jnlp that launches SignedJnlpResource class.
	* tests/jnlp_tests/signed/ExtensionJnlp/testcases/ExtensionJnlpTest.java:
	Testcase that tests the launching of jnlp files containing extension jnlps
	as resource.
	* tests/jnlp_tests/signed/SignedJarResource/resources/SignedJarResource1.jnlp:
	Component jnlp file that is used as an extension resource.
	* tests/jnlp_tests/signed/SignedJarResource/srcs/SignedJarResource.java:
	A simple java class that outputs a string.
	* tests/jnlp_tests/signed/SignedJnlpResource/resources/SignedJnlpResource1.jnlp:
	Component jnlp file that is used as an extension resource that does not
	match the signed jnlp file.
	* tests/jnlp_tests/signed/SignedJnlpResource/resources/SignedJnlpResource2.jnlp:
	Component jnlp file that is used as an extension resource that matches the
	signed jnlp file.
	* 
tests/jnlp_tests/signed/SignedJnlpResource/srcs/JNLP-INF/APPLICATION_TEMPLATE.jnlp:
	Signed Jnlp File.
	* tests/jnlp_tests/signed/SignedJnlpResource/srcs/SignedJnlpResource.java:
	A simple java class that outputs a string.

-- 
Cheers,
Saad Mohammad


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix05.patch
Type: text/x-patch
Size: 9083 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120626/a92ef6cb/fix05.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: changelog03.patch
Type: text/x-patch
Size: 2772 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120626/a92ef6cb/changelog03.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reproducers03.patch
Type: text/x-patch
Size: 33489 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120626/a92ef6cb/reproducers03.patch