[rfc] [icedtea-web] get rid of (most of) repeated runs of tests

[Jiri Vanek]

ping.. getting  urgent

-------- Original Message --------
Subject: [rfc] [icedtea-web] get rid of (most of) repeated runs of tests
Date: Thu, 21 Jun 2012 20:39:59 +0200
From: Jiri Vanek <jvanek at redhat.com>
To: IcedTea Distro List <distro-pkg-dev at openjdk.java.net>

Hi!

Recently I have noticed that before each coverage run, *ALL* testsuites are run
This is making run of pure run-test-code-coverage six time longer, and does not matter waht was run 
before.
Also I have noticed that pac tests and unit tests are rerun always. PAc tests were just not stamped, 
but unit? hmmm

This patch is fixing all issues except one:
* run-test-code-coverage will not rerun run-unit-test-code-coverage nor run-dist-test-code-coverage 
if already run
* run-unit-test-code-coverage  will not rerun unittests nor pac tests if run
* run-dist-test-code-coverage  will not rerun netx-dist-tests
* run-netx-unit-tests will not rerun pac tests if already run

Also all above (except run-netx-unit-tests)  will  stdout "nothing to do for..." if already run.
The  run-netx-unit-tests behave strangely...  If run, they always run again. I have not discovered 
why :-/.
Make -d is printing  out that  stamps/run-netx-unit-tests.stamp do not exist. But I ensure several 
times that it does (eg test -f  in target :-/).

The only nasty thing in this patch is copy-pasted code from netx-dist-tests-remove-cert-from-public 
to stamps/exported-test-certs.stamp.
The fact that all reproducers runs were depending on unstamped file was cause of their repeated 
reruning. Any idea how to do this better without duplicing welcomed.
Just note, that remoal must be always run, so just stamped call of 
netx-dist-tests-remove-cert-from-public will not help.


Thanx in advice, J.



2012-06-21  Jiri Vanek  <jvanek at redhat.com>

	Removed repeated re-runing of tests during coverage, stamped pac tests
	* Makefile.am: (check-pac-functions) moved to target aliases and replaced
	by stamps/check-pac-functions.stamp.
	(clean-netx-unit-tests) added removing of  stamps/check-pac-functions.stamp
	(stamps/exported-test-certs.stamp): no longer depends on
	netx-dist-tests-remove-cert-from-public, logic of it have to be
	copy-pasted from here.
	(stamps/run-unit-test-code-coverage.stamp): no longer depends on check,
	but was added direct dependences

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixedRerunningOfTAlltests.diff
Type: text/x-patch
Size: 3853 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120628/be349256/fixedRerunningOfTAlltests.diff