[rfc][icedtea-web] extended reflection tests

[Danesh Dadachanji]

Hi Jiri,

Thanks for the tests!

On 05/03/12 07:55 AM, Jiri Vanek wrote:
> Hi! Few more test to reflection
>
> What I'm surprised is, that unsigned application can use reflection at
> all. I tough they can not....

I thought so too..

> This text is expecting them unsigned ones using reflection as correct as
> it is current behaviour. But feel free to correct me if  unsigned
> applications should  have reflection forbidden.

I'll let someone who knows more comment on this. Until then, I have some 
comments on the patch below.

>
> 2012-03-05  Jiri Vanek <jvanek at redhat.com>
>
>      Improved reflection test:
>      *
> /home/jvanek/hg/icedtea-web/tests/jnlp_tests/simple/AccessClassInPackage/testcases/AccessClassInPackageTest.java:
>
>      This testcase was extended for three more unsigned reflection tries
> and four signed
>      */home/jvanek/hg/icedtea-web/tests/jnlp_tests/simple/AccessClassInPackage/srcs/AccessClassInPackage.java:
>      now accepting class to be findByName as argument. Four new jnlp
> files in
>      signed a four in simple are then passing  those argument
>      */home/jvanek/hg/icedtea-web/tests/jnlp_tests/simple/AccessClassInPackage/resources/AccessClassInPackageSUNSEC.jnlp:
>      */home/jvanek/hg/icedtea-web/tests/jnlp_tests/simple/AccessClassInPackage/resources/AccessClassInPackageNETSF.jnlp:
>      */home/jvanek/hg/icedtea-web/tests/jnlp_tests/simple/AccessClassInPackage/resources/AccessClassInPackageJAVAXJNLP.jnlp:
>      */home/jvanek/hg/icedtea-web/tests/jnlp_tests/simple/AccessClassInPackage/resources/AccessClassInPackageSELF.jnlp:
>      */home/jvanek/hg/icedtea-web/tests/jnlp_tests/simple/AccessClassInPackage/resources/AccessClassInPackage.jnlp:
>      removed

Don't think we need your full path of "/home/jvanek/hg/icedtea-web/" ;)

Please can you add <vendor> to all the jnlp files. It'd work right now 
but once the changeset I have in review is accepted, it'll start failing 
to run javaws altogether.

I believe you also need to add the copyright header for many of the files.

> +    private String[] badExceptions = {
> +        "accessClassInPackage.javax.jnlp.ServiceManager)",
> +        "accessClassInPackage.AccessClassInPackage)",
> +        "accessClassInPackage.net.sourceforge.jnlp)",
> +        "accessClassInPackage.sun.security.internal.spec)"

[snip]

> +    private void testShouldFail(ServerAccess.ProcessResult pr, String s) {
> +        String c = "java.security.AccessControlException: access denied (java.lang.RuntimePermission " + s;
> +        Assert.assertTrue("stderr should contains `" + c + "`, but didn't ", pr.stderr.contains(c));
> +    }
> +    private void testShouldNOTFail(ServerAccess.ProcessResult pr, String s) {
> +        String c = "java.security.AccessControlException: access denied (java.lang.RuntimePermission " + s;
> +        Assert.assertFalse("stderr should NOT contains `" + c + "`, but did ", pr.stderr.contains(c));
> +    }


I noticed testShouldFail asserts were always failing when the methods 
were being called. I believe you need to add double quotes around 
java.lang.RuntimePermission and s in order for contains() to pass.

stderr.log outputted:
[...] access denied ("java.lang.RuntimePermission" 
"accessClassInPackage.sun.security.internal.spec")

Change the String c's to (\"java.lang.RuntimePermission\" and wrap each 
element of badExceptions similarly, that should take care of the problem.


Once the above's sorted out, this looks good to me for pushing.

Regards,
Danesh