[rfc][icedtea-web] extended reflection tests

[Danesh Dadachanji]

On 07/03/12 11:34 AM, Jiri Vanek wrote:
> On 03/07/2012 04:58 PM, Danesh Dadachanji wrote:
>>
>>
>> On 07/03/12 06:01 AM, Jiri Vanek wrote:
>>> On 03/06/2012 05:59 PM, Danesh Dadachanji wrote:
>>>>
>>>> Interesting, my F16 has "" around it. I built it with stock 6 (did not
>>>> use --with-jdk-home).
>>>>
>>>> I don't think using matches with .* is the best idea. In this case,
>>>> pr.stderr is a String, right? That means that if let's say stderr
>>>> contains "java.security.AccessControlException" and then somewhere
>>>> later on contains the other part we're searching for, it will return
>>>> true.
>>>>
>>>
>>> True. I tought you will complain like this :)
>>> What do you think about this?
>>>
>>> private void testShouldFail(ServerAccess.ProcessResult pr, String s) {
>>> String c = "(?s).*java.security.AccessControlException.{0,5}access
>>> denied.{0,5}java.lang.RuntimePermission.*" + s + ".*";
>>> Assert.assertTrue("stderr should match `" + c + "`, but didn't ",
>>> pr.stderr.matches(c));
>>> }
>>>
>>> private void testShouldNOTFail(ServerAccess.ProcessResult pr, String
>>> s) {
>>> String c = "(?s).*java.security.AccessControlException.{0,5}access
>>> denied.{0,5}java.lang.RuntimePermission.*" + s + ".*";
>>> Assert.assertFalse("stderr should NOT match `" + c + "`, but did ",
>>> pr.stderr.matches(c));
>>> }
>>>
>>>
>>
>> Ah nice way of doing it! One more nitpick though, sorry! Could you
>> replace the .* after java.lang.RuntimePermission with .{0,5} too?
> Of course! I have overlooked!
>>
>> ".{0,5}java.lang.RuntimePermission.{0,5}"
>>
>> The problem mentioned last time would still occur here, in that if
>> there was a RuntimePermission exception somewhere in stderr and s
>> appears somewhere later on, it would match. This might not be what
>> we're looking for either.
>>
>> Thanks and sorry for the headaches!
>
> NP! They are welcomed. Can I commit with fix:
>
> private void testShouldFail(ServerAccess.ProcessResult pr, String s) {
> String c = "(?s).*java.security.AccessControlException.{0,5}access
> denied.{0,5}java.lang.RuntimePermission.{0,5}" + s + ".*";
> Assert.assertTrue("stderr should match `" + c + "`, but didn't ",
> pr.stderr.matches(c));
> }
>
> private void testShouldNOTFail(ServerAccess.ProcessResult pr, String s) {
> String c = "(?s).*java.security.AccessControlException.{0,5}access
> denied.{0,5}java.lang.RuntimePermission.{0,5}" + s + ".*";
> Assert.assertFalse("stderr should NOT match `" + c + "`, but did ",
> pr.stderr.matches(c));
> }
>

Awesome, thanks! This looks good to me, go ahead and push.

>
>>
>> Regards,
>> Danesh
>