[RFC][icedtea-web] Launch errors are not being printed to terminal.

[Omair Majid]

On 03/12/2012 10:59 AM, Danesh Dadachanji wrote:
> On 11/03/12 12:01 AM, Omair Majid wrote:
>> On 03/09/2012 12:16 PM, Danesh Dadachanji wrote:
>>> If javaws is run with -headless and a launch error occurs, no message is
>>> printed and javaws exits.
>>
>> By no message do you mean nothing at all (or is a single line message
>> printed without an exception stack trace)?
>>
> 
> Unfortunately nothing at all. I would not have noticed this if it
> printed something. =) The method printMessage() setup that one-liner
> that needed to be printed but never actually did the printing. :/

>From the point of view of a user (and not a test), I would think that
single line error message explaining what went wrong would be more
important than a stack trace (which would be meaningless to most users).

> Don't think I mentioned this in the original email but the reason behind
> -headless or -verbose printing a stack trace is to make it similar to
> when neither are passed. In this case, javaws prints the dialog with a
> stack trace so in order to make -headless act similarly, Jiri and I
> concluded it would be best to print the entire stacktrace if just
> -headless was passed (regardless of -verbose).
> 

I think it would be better to leave out the stack trace in headless
mode, but if others think that the stack trace should be printed, then
that's fine by me.

> I thought so too until I checked where printMessage() was called from.
> See launchWarning in GuiLaunchHandler[1], it explicitly calls
> DefaultLaunchHandler.printMessage(). I didn't look into why it was doing
> that so if you think that's a bug, I can look into it further.

That might be best. The more we can get rid of these corner cases and
conditionals, the fewer bugs we should have.

Cheers,
Omair