[icedtea-web] RFC: Patch to fix PR895

[Omair Majid]

On 03/12/2012 02:20 PM, Deepak Bhole wrote:
> * Deepak Bhole <dbhole at redhat.com> [2012-03-12 14:13]:
>> * Omair Majid <omajid at redhat.com> [2012-03-09 20:08]:
>>> On 03/09/2012 05:19 PM, Deepak Bhole wrote:
>>>> Hi,
>>>>
>>>> Attached patch fixes PR895:
>>>> "IcedTea-Web searches for missing classes on each loadClass or findClass"
>>>>
>>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=895
>>>
>>> The bug doesn't seem to have any additional information. Is there a test
>>> case or a reproducer? Do you know why the server is being hammered? If
>>> the actual issue is under our control (for example, we are attempting to
>>> re-download stuff we already downloaded), it might be better to fix this
>>> underlying issue.
>>>
>>
>> Yes, this one:
>> http://jdk6.java.net/nonav/plugin2/liveconnect/LiveConnectTests/
>>

Please do add this to
http://icedtea.classpath.org/wiki/IcedTea-Web-Tests as well.

>> Without the patch it takes 2+ minutes to run.. with patch, it is down to
>> about 15 seconds.
>>

Do you know what this test is doing? While the patch looks fine, I would
hate for us to paper over the problem rather than fixing it.

>>
>> While writing the above, I realized that it is really just CBCL that we
>> want to fix. What about moving the logic just into CBCL? See attached
>> patch.
>>
> 
> annndddd... here is the patch
> 

Just one request: can you please add a unit test for this classloader so
we can verify that this behaviour does not regress later?

Thanks,
Omair