[RFC][icedtea-web] Launch errors are not being printed to terminal.
Omair Majid
omajid at redhat.com
Wed Mar 14 08:32:40 PDT 2012
On 03/14/2012 09:56 AM, Danesh Dadachanji wrote:
> On 13/03/12 06:00 PM, Omair Majid wrote:
>> Sorry, I was a little confused (the original patch had an 'if
>> JNLPRuntime.isDebug()). I prefer printMessage here too because of the
>> consistency. I should probably add unit tests for the GUI too, except
>> it's a little coupled with a bunch of other things.
>>
>
> For something like this, GUI shouldn't be too troublesome, all you need
> to do is pass in the -verbose option to the javaws call. Jiri has passed
> in params in some other jnlp_tests, refer to those. The catch is _not_
> running it in headless, I'm just not sure how you'd go about killing it
> and getting rid of that error dialog.
I meant unit tests, not system-level/integration tests :) Aside from the
user-interaction issues, unit tests are a lot more predictable and
faster. Plus I can run them from my favourite ide.
I haven't had much luck recently in running the javaws tests recently
either. Running 'make run-netx-dist-tests' always seems to hang for some
reason.
>
> My pleasure! Thanks for cleaning this all up. This looks good to me, go
> ahead and push.
Pushed as changeset 905383606ece.
Cheers,
Omair
More information about the distro-pkg-dev
mailing list