[icedtea-web] RFC: Patch to fix PR895

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2012-03-13 16:49]:
> On 03/13/2012 04:19 PM, Deepak Bhole wrote:
> > * Omair Majid <omajid at redhat.com> [2012-03-13 10:05]:
> >> On 03/13/2012 09:59 AM, Deepak Bhole wrote:
> >>> Ah, yeah I thought of checking for time too but I was hoping to avoid it
> >>> as it is not reliable. In any case, given that neither of us have a
> >>> better way in mind, I guess this is better than nothing :)
> >>>
> >>
> >> Yeah, that's what I was thinking too. If we find a cleaner way to do
> >> this check later on, we can always change things.
> >>
> >>>> As a side note, we should really try and reduce the inter-dependencies
> >>>> (between the classloader, jnlpfile and downloading), but this works for now.
> >>>>
> >>>
> >>> Yeah :/ there have been other cases where this has been a hindrance to
> >>> writing tests too.
> >>
> >> I will poke at this some more when I have some spare time.
> >>
> >>> Are you OK with the content of the patch?
> >>
> >> Yeah, I think it's fine for 1.1 and 1.2. It looks like you agree that we
> >> should wait a bit for HEAD, and that sounds fine to me too.
> >>
> > 
> > Sorry, I misread the previous message. I thought we were talking about
> > the fix to the C++ side and to put it in HEAD only initially.
> > 
> > I think that this fix should go into all branches. IMO regardless of the
> > fact that the C++ side may be causing excessive hammering, we should
> > still make it so that we don't hit the server over and over for a class
> > that we know does not exist (for that instance).
> > 
> 
> Fair enough. I am okay with the patch.
> 

Thanks! Pushed:
http://icedtea.classpath.org/hg/icedtea-web/rev/a988f5155172
http://icedtea.classpath.org/hg/release/icedtea-web-1.1/rev/d4a6d82ed0ae
http://icedtea.classpath.org/hg/release/icedtea-web-1.2/rev/9b8837c53c09

Cheers,
Deepak