Reviewer needed: backport of "6469266: Integrate Apache XMLSec 1.4.2 into JDK 7" into IcedTea6

[Jiri Vanek]

On 03/16/2012 06:02 PM, Andrew Hughes wrote:
> ----- Original Message -----
>> Andrew Hughes wrote:
>>> ----- Original Message -----
>>>> Andrew Hughes wrote:
>>>>> ----- Original Message -----
>>>>>> Andrew Hughes wrote:
>>>>>>> ----- Original Message -----
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I'd like to add following "small" (well 1MB of size ;-)
>>>>>>>> backport
>>>>>>>> to
>>>>>>>> IcedTea6:
>>>>>>>> "6469266: Integrate Apache XMLSec 1.4.2 into JDK 7"
>>>>>>>>
>>>>>>>> This patch fixes (among other thing) following issue:
>>>>>>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=881
>>>>>>>>
>>>>>>>> hg diff created against recent IcedTea6 HEAD version is stored
>>>>>>>> in
>>>>>>>> an
>>>>>>>> attachment
>>>>>>>> in a BZIP archive (because I don't want to send quite big 1MB
>>>>>>>> attachment to public mail list).
>>>>>>>>
>>>>>>>> Please note that it's not a direct backport because of (quite
>>>>>>>> minor)
>>>>>>>> differences
>>>>>>>> between IT6 and OpenJDK7 sources. This patch applies cleanly
>>>>>>>> and
>>>>>>>> it
>>>>>>>> does not
>>>>>>>> seem to cause any compatibility issues.
>>>>>>>>
>>>>>>>> Here's ChangeLog entry:
>>>>>>>>
>>>>>>>> 2012-02-28  Pavel Tisnovsky<ptisnovs at redhat.com>
>>>>>>>>
>>>>>>>> 	* Makefile.am: Add new patch.
>>>>>>>> 	* NEWS: Mention backport.
>>>>>>>> 	*
>>>>>>>> 	patches/openjdk/6469266-Integrate_Apache_XMLSec_1_4_2.patch:
>>>>>>>> 	Backport of S6469266: Integrate Apache XMLSec 1.4.2 into JDK
>>>>>>>> 	7
>>>>>>>>
>>>>>>>>
>>>>>>>> Can anybody please review this change?
>>>>>>>>
>>>>>>>> Thank you in advance,
>>>>>>>> Pavel
>>>>>>>>
>>>>>>> What's the motivation for this?  Does the proprietary JDK 6 use
>>>>>>> this version?
>>>>>> Can not say anything about JDK 6, but tests mentioned here:
>>>>>>
>>>>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=881
>>>>>>
>>>>>> failed only on IcedTea6. IT7/O7 looks ok, the same for
>>>>>> proprietary
>>>>>> JDK6.
>>>>>>
>>>>>> Pavel
>>>>>>
>>>>>>
>>>>> Yes, but IcedTea6/OpenJDK6 has to meet the Java 6 specification.
>>>>> IcedTea7/OpenJDK7 obviously don't.  Do you have a link to the
>>>>> original
>>>>> changeset?
>>>> Hi Andrew,
>>>>
>>>> here's bug with description:
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6469266
>>>>
>>>> and here the original changeset:
>>>> http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/74fc78477907
>>>>
>>>
>>> Ok the problem with this remains, as noted before, that the
>>> granularity
>>> of this patch is not sufficient.  This bug&  changeset aren't in
>>> reference
>>> to the issue you've found, but constitute updates for an entire
>>> API.
>>
>> Well, so let's forget the issue for a moment. Is there any problem in
>> updating
>> *internal* library which does not change the official Java SE API?
>>
>> The original changeset is named "Integrate Apache XMLSec 1.4.2 into
>> JDK 7", but
>> I see no reason why not to backport it to IT6. Moreover when we know
>> it fixes
>> at least one issue.
>>
>
> That's the same issue I'm talking about.  Unless the proprietary JDK6 is
> known to have also upgraded to 1.4.2, we shouldn't do this.
I'm afraid that this will be necessary to be kept as inside-rpm patch then :(

J.
>
>>>
>>> You need to find the actual bug fix and import that.  I suggest
>>> looking at
>>> whatever project this was imported from.
>> project? It's a whole library included in JDK:
>> http://santuario.apache.org/
>>
>>>
>>>> Pavel
>>>>
>>>
>>
>>
>