Reviewer needed: IcedTea6 HEAD - Fix for NameSpaceSymbTable class from Apache XML internal security library.

[Andrew Hughes]

----- Original Message -----
> Andrew Hughes wrote:
> > ----- Original Message -----
> >> Andrew Hughes wrote:
> >>> ----- Original Message -----
> >>>> Hi all,
> >>>>
> >>>> I'd like to push following patch to IcedTea6 HEAD. This patch
> >>>> fixes
> >>>> one issue in
> >>>> NameSpaceSymbTable class from Apache XML internal, security
> >>>> library.
> >>>>
> >>>> hg diff created against recent IcedTea6 HEAD is stored in an
> >>>> attachment.
> >>>>
> >>>>
> >>>> ChangeLog entry:
> >>>>
> >>>> 2012-03-20  Pavel Tisnovsky  <ptisnovs at redhat.com>
> >>>>
> >>>>         * patches/apache-xml-internal-fix.patch:
> >>>>         Fix for NameSpaceSymbTable class from Apache XML
> >>>>         internal
> >>>>         security library.
> >>>>
> >>>> Can anybody please review this change?
> >>>>
> >>> Is this from the mega-patch you posted before?
> >> yes, this is part of the mega-patch
> >>
> >>> Has this gone upstream?
> >> if you mean by upstream Apache XML sec. project - yes, it's part
> >> of
> >> changes made in this project (these changes are
> >> quite hard to spot as the sources were regularly reformatted :-|)
> >>
> > 
> > No, I mean OpenJDK6.
> 
> No, it's not part of OpenJDK6. I thought it should go to IcedTea6
> first.
> 

Well, it should go there too and they are better placed to review it.

You haven't provided any explanation as to what this actually fixes
and why this change is appropriate, so I can't really review it as it
stands.

> > 
> >>>> Thank you in advance,
> >>>> Pavel
> >>>>
> >>>>
> >>>>
> >>>> [Text File:hg.diff]
> >>>>
> >>
> > 
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07