Reviewer needed: fix for IcedTea bug#881 (IcedTea6 HEAD)

[Andrew Hughes]

----- Original Message -----
> On Wed, Mar 21, 2012 at 2:42 PM, Andrew Hughes <ahughes at redhat.com>
> wrote:
> > ----- Original Message -----
> >> Andrew Hughes wrote:
> >> > ----- Original Message -----
> >> >> Hi,
> >> >>
> >> >> I'd like to push following patch to IcedTea6 HEAD.
> >> >> This patch fixes the bug #881:
> >> >> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=881
> >> >>
> >> >> Patch contains only minimal (but still functional) changes
> >> >> needed
> >> >> to be made in Apache XML Security libraries. I've excluded
> >> >> other
> >> >> changes which is IMHO important, but not directly related to
> >> >> #881.
> >> >>
> >> >> (FYI: there's no API changes)
> >> >>
> >> >> ChangeLog entry:
> >> >>
> >> >> 2012-03-21  Pavel Tisnovsky  <ptisnovs at redhat.com>
> >> >>
> >> >>         PR881: Sign tests (wsse.policy.basic) failures with
> >> >>         OpenJDK6
> >> >>         * Makefile.am: Updated
> >> >>         * patches/idresolver_fix.patch: added patch for a class
> >> >>         IdResolver.
> >> >>
> >> >> Could anybody please review this change?
> >> >>
> >> >> Thank you in advance,
> >> >> Pavel
> >> >>
> >> >>
> >> >> [Text File:hg.diff]
> >> >>
> >> >
> >> > What is this patch changing?  It's hard to tell as there are so
> >> > many whitespace
> >> > changes.
> >>
> >> The most important thing is that there are added two new
> >> namespaces
> >> (in a static String array transformed into a List).
> >>
> >> And the logic for searching of element types are: 1) slightly
> >> faster
> >> 2) has added new branches for elementIndex==4 and
> >> elementIndex==5
> >>
> >
> > And what do these changes fix?
> 
> Seems to be mostly this:
> 
> http://svn.apache.org/viewvc?view=revision&revision=393799
> http://svn.apache.org/viewvc?view=revision&revision=518162
> 

Thanks Stefan.

Pavel, is applying https://svn.apache.org/viewvc/xml/security/trunk/src/org/apache/xml/security/utils/IdResolver.java?r1=518162&r2=518161&pathrev=518162&view=patch not enough?
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07