Reviewer needed: fix for IcedTea bug#881 (IcedTea6 HEAD)

[Andrew Hughes]

----- Original Message -----
> Andrew Hughes wrote:
> > ----- Original Message -----
> >> Andrew Hughes wrote:
> >>> ----- Original Message -----
> >>>> On Wed, Mar 21, 2012 at 2:42 PM, Andrew Hughes
> >>>> <ahughes at redhat.com>
> >>>> wrote:
> >>>>> ----- Original Message -----
> >>>>>> Andrew Hughes wrote:
> >>>>>>> ----- Original Message -----
> >>>>>>>> Hi,
> >>>>>>>>
> >>>>>>>> I'd like to push following patch to IcedTea6 HEAD.
> >>>>>>>> This patch fixes the bug #881:
> >>>>>>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=881
> >>>>>>>>
> >>>>>>>> Patch contains only minimal (but still functional) changes
> >>>>>>>> needed
> >>>>>>>> to be made in Apache XML Security libraries. I've excluded
> >>>>>>>> other
> >>>>>>>> changes which is IMHO important, but not directly related to
> >>>>>>>> #881.
> >>>>>>>>
> >>>>>>>> (FYI: there's no API changes)
> >>>>>>>>
> >>>>>>>> ChangeLog entry:
> >>>>>>>>
> >>>>>>>> 2012-03-21  Pavel Tisnovsky  <ptisnovs at redhat.com>
> >>>>>>>>
> >>>>>>>>         PR881: Sign tests (wsse.policy.basic) failures with
> >>>>>>>>         OpenJDK6
> >>>>>>>>         * Makefile.am: Updated
> >>>>>>>>         * patches/idresolver_fix.patch: added patch for a
> >>>>>>>>         class
> >>>>>>>>         IdResolver.
> >>>>>>>>
> >>>>>>>> Could anybody please review this change?
> >>>>>>>>
> >>>>>>>> Thank you in advance,
> >>>>>>>> Pavel
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> [Text File:hg.diff]
> >>>>>>>>
> >>>>>>> What is this patch changing?  It's hard to tell as there are
> >>>>>>> so
> >>>>>>> many whitespace
> >>>>>>> changes.
> >>>>>> The most important thing is that there are added two new
> >>>>>> namespaces
> >>>>>> (in a static String array transformed into a List).
> >>>>>>
> >>>>>> And the logic for searching of element types are: 1) slightly
> >>>>>> faster
> >>>>>> 2) has added new branches for elementIndex==4 and
> >>>>>> elementIndex==5
> >>>>>>
> >>>>> And what do these changes fix?
> >>>> Seems to be mostly this:
> >>>>
> >>>> http://svn.apache.org/viewvc?view=revision&revision=393799
> >>>> http://svn.apache.org/viewvc?view=revision&revision=518162
> >>>>
> >>> Thanks Stefan.
> >>>
> >>> Pavel, is applying
> >>> https://svn.apache.org/viewvc/xml/security/trunk/src/org/apache/xml/security/utils/IdResolver.java?r1=518162&r2=518161&pathrev=518162&view=patch
> >>> not enough?
> >> Sorry no, because it is a patch applicable for a code newer that
> >> the
> >> one used in OpenJDK6. For example, the old code
> >> uses Element []els=new Element[5]; which is not correct as there
> >> are
> >> now 6 element types etc.
> >>
> >> Pavel
> >>
> >>
> > 
> > Right.  Ok, let's get both of these XML fixes in, but also get them
> > upstreamed to
> > OpenJDK 6 too.
> 
> Thanks,
> 
> may I use my patch (containing both fixes) or should I use the
> patches taken from SVN revisions (which on the other hand
> alter the code even more - changing API of the IdResolver class, for
> example)?
> 
> OpenJDK6 - agreed.
> 
> 

Sorry, to clarify; yes please push the two patches you posted initially
for this issue and the other XML issue in the other thread:

http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-March/017783.html

and look at getting them into OpenJDK6.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07