[RFC] DefaultLaunchHandlerTest - fix imports

Omair Majid omajid at redhat.com
Fri Mar 23 16:12:30 PDT 2012


On 03/23/2012 06:58 PM, Thomas Meyer wrote:
> diff -r 540254dcb2b3 -r 4ec09b4791b9 tests/netx/unit/net/sourceforge/jnlp/DefaultLaunchHandlerTest.java
> --- a/tests/netx/unit/net/sourceforge/jnlp/DefaultLaunchHandlerTest.java	Sun Mar 18 12:25:49 2012 +0100
> +++ b/tests/netx/unit/net/sourceforge/jnlp/DefaultLaunchHandlerTest.java	Thu Mar 22 22:38:56 2012 +0100
> @@ -43,6 +43,10 @@
>  import java.io.ByteArrayOutputStream;
>  import java.io.PrintStream;
>  
> +import net.sourceforge.jnlp.DefaultLaunchHandler;
> +import net.sourceforge.jnlp.LaunchException;
> +import net.sourceforge.jnlp.ParseException;
> +

This looks really weird. DefaultLaunchHandlerTest is in the
net.sourceforge.jnlp package. Why would it need to import the classes in
the same package?

Are you running into some sort of error without this patch? 'make check'
works fine for me and shows all tests in DefaultLaunchHandlerTest pass.

Cheers,
Omair



More information about the distro-pkg-dev mailing list