[icedtea-web] RFC: Fix pac tests

[Jiri Vanek]

On 03/24/2012 08:13 AM, Omair Majid wrote:
> Hi,
>
> The attached patch fixes the pac tests. With the patch applied, the
> results change from:
>
> Test results: passed: 220; failed: 64;
>
> to:
>
> Test results: passed: 285; failed: 0;
>
> I have rewritten the testDateRange* tests so date wrapping is handled
> correctly. I also discovered two bugs in pac-funcs.js (yes, tests help
> find bugs!) and I have fixed those too.
>
> Okay to commit?
>
> Thanks,
> Omair

Hi! The logic itself looks ok. The fullYear() fix can go inside immediately (as separate patch)
But fixes inside /tests/netx/pac/pac-funcs-test.js contains both cosmetic and  functional fixes. Can 
you please separate them? (I think that cosmetic ones can go inside imidietly without nay more 
reviewing)

/me hopes not to make you angry to much :(


When I was checking this issue I wanted to fix it, but now when I have seen your change-set  I'm 
very happy I did not so. Tyvm for very deep fix!


J.