[PATCH 0 of 2] Add systemtap tapset tests

[Jon VanAlten]

----- Original Message -----
> From: "Mark Wielaard" <mjw at redhat.com>
> To: distro-pkg-dev at openjdk.java.net
> Cc: "Jon VanAlten" <jon.vanalten at redhat.com>
> Sent: Friday, March 23, 2012 6:49:52 PM
> Subject: [PATCH 0 of 2] Add systemtap tapset tests
> 
> Hi,
> 
> These patches add the test framework that Jon wrote for testing the
> systemtap tapset probes. It adds a large number of tests (498 probes
> are tested). The first patch is largely Jon's work, I just tweaked it
> a bit to make it a little more robust. The second patch just extends
> the jstaptest.pl to add a couple of explicit jstack tests (simple and
> full).
> 

Hi Mark,

Thanks for resurrecting these!

> Jon, if you could take a look that would be appreciated. The changes
> I made to your original were:
> - Switched detect_probes from a negative test (see if the stap -l
> fails)
>   to a positive test (see if that stap -l output matches the expected
>   probe name). And use -L to force expansion of all arguments.
> - Added an explicit stap script run test to make sure the user has
>   enough permissions (and if not skip the actual probe tests).
> - Made the test program do a little more so method_compiled tests
>   have enough time to detect all probe events (specifically run some
>   triggers twice with a small Thread.sleep in between to give hotspot
>   enough time to finish the jit compilation of a method).
> 

Well, Present-Jon does see opportunities for improvements to the code
that Past-Jon wrote way back then, but it does still look like it
does what it is meant to do, and your improvements are sensible.  I
approve :)

cheers,
jon