Reviewer needed: backport of "6792400: Avoid loading of Normalizer resources, for simple uses" into IcedTea6 HEAD

Pavel Tisnovsky ptisnovs at redhat.com
Tue Mar 27 03:22:29 PDT 2012 

Jiri Vanek wrote:
> On 03/26/2012 06:47 PM, Pavel Tisnovsky wrote:
>> Jiri Vanek wrote:
>>> On 03/26/2012 06:18 PM, Pavel Tisnovsky wrote:
>>>> Jiri Vanek wrote:
>>>>> On 03/26/2012 04:02 PM, Pavel Tisnovsky wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I'd like to push following backport to IcedTea6 HEAD (and to OpenJDK6
>>>>>> too - will do parallel request):
>>>>>> "6792400: Avoid loading of Normalizer resources, for simple uses".
>>>>>>
>>>>>> This backport fixes following IT6 bug:
>>>>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=882
>>>>>>
>>>>>> hg diff created against recent IcedTea6 HEAD is stored in an
>>>>>> attachment.
>>>>>>
>>>>>> ChangeLog entry:
>>>>>> 2012-03-26  Pavel Tisnovsky<ptisnovs at redhat.com>
>>>>>>
>>>>>>            *
>>>>>> patches/openjdk/6792400-Avoid_loading_Normalizer_resources.patch:
>>>>>>            Backport of: 6792400: Avoid loading of Normalizer
>>>>>> resources
>>>>>>            for simple uses
>>>>>>            * NEWS: Mention backport.
>>>>>>            * Makefile.am: Updated
>>>>>>
>>>>>> This backport works correctly - passed all regular tests.
>>>>>>
>>>>>> Can anybody please review this change?
>>>>>>
>>>>>> Thank you in advance,
>>>>>> Pavel
>>>>>
>>>>> Hi!
>>>>>
>>>>> I have walked across the change set and I have few questins:
>>>>
>>>> Thanks Jiri!
>>>>
>>>>>
>>>>> -Sun bugzilla is mentioning, that it is "just" performance
>>>>> improvement.
>>>>>    ?
>>>>> -As far as I know, the Jira was falling _inside_ normalize
>>>>> method(s), so
>>>>> this fix looks like not fixing the issue, but just to walk-around for
>>>>> just-ascii texts.
>>>>
>>>> The method for string normalization is called from the static block
>>>> and it throws
>>>> exception when called with ASCII-only string. There's nothing which
>>>> should be
>>>> normalized in such strings ;-)
>>>>
>>>>>    Am I right?
>>>>>    Was the jira failures caused just-by-ascii input files?
>>>>
>>>> Yes. To be precise - it does not work with test files but only with
>>>> text strings.
>>>>
>>>>> -I know that you have dig around to find "some fixing backport", so
>>>>> there is none fixing just corrupted normalizer?
>>>>
>>>> It's not needed at all to fix bug #882 and as you know nobody were
>>>> happy with
>>>> 1MB patch ;-) I could try to find a fix for the normalizer, but it
>>>> won't be
>>>> immediate which will slows us down.
>>>>
>>>>> -Also I know that the reproducer was quite complicated, but still, can
>>>>> you ssy little bit more about it?
>>>>
>>>> Hmm I could try to export a ST from the test reports.
>>>>
>>>>>
>>>>> I do not believe there is direct fix for this issue, and unless
>>>>> there is
>>>>> one, and this is the last of backport for jira issue this should go in
>>>>> no metter how much I dont like it :)
>>>>
>>>> Heh what's wrong with this patch. After all it'll make IcedTea6 quite
>>>> quicker :-)
>>>>
>>>>>
>>>>> Thanx for dooing it.
>>>>>     J.
>>>>
>>>
>>> Ok... Last question:
>>>
>>> I have tried to reproduce.. Then I have seen the original reproducer..
>>> omg...
>>>
>>> Can you just explain what te reprodcuer is trying to do?
>>
>> The reproducer is trying to check if correct wsdl is generated from a
>> Java
>> file containing WS-related annotations.
> 
> %-/
> 
> I have hoped for some simple reproducer which is sending corrupted
> string to the method :((
Here's ST and before them is the string which caused the failure:

*** normalize *** 'cn=red hat code signing ca'
Exception in thread "main" java.lang.ExceptionInInitializerError
        at sun.text.normalizer.NormalizerBase.decompose(NormalizerBase.java:725)
        at sun.text.normalizer.NormalizerBase$NFKDMode.normalize(NormalizerBase.java:366)
        at sun.text.normalizer.NormalizerBase.normalize(NormalizerBase.java:1611)
        at sun.text.normalizer.NormalizerBase.normalize(NormalizerBase.java:1591)
        at java.text.Normalizer.normalize(Normalizer.java:164)
        at sun.security.x509.AVA.toRFC2253CanonicalString(AVA.java:1003)
        at sun.security.x509.RDN.toRFC2253StringInternal(RDN.java:447)
        at sun.security.x509.RDN.toRFC2253String(RDN.java:426)
        at sun.security.x509.X500Name.getRFC2253CanonicalName(X500Name.java:731)
        at sun.security.x509.X500Name.equals(X500Name.java:417)
        at sun.security.pkcs.PKCS7.getCertificate(PKCS7.java:626)
        at sun.security.pkcs.SignerInfo.getCertificate(SignerInfo.java:219)
        at sun.security.pkcs.SignerInfo.verify(SignerInfo.java:345)
        at sun.security.pkcs.PKCS7.verify(PKCS7.java:511)
        at sun.security.pkcs.PKCS7.verify(PKCS7.java:528)
        at sun.security.util.SignatureFileVerifier.processImpl(SignatureFileVerifier.java:216)
        at sun.security.util.SignatureFileVerifier.process(SignatureFileVerifier.java:193)
        at java.util.jar.JarVerifier.processEntry(JarVerifier.java:251)
        at java.util.jar.JarVerifier.update(JarVerifier.java:205)
        at java.util.jar.JarFile.initializeVerifier(JarFile.java:338)
        at java.util.jar.JarFile.getInputStream(JarFile.java:403)
        at sun.misc.JarIndex.getJarIndex(JarIndex.java:116)
        at sun.misc.URLClassPath$JarLoader$1.run(URLClassPath.java:623)
        at java.security.AccessController.doPrivileged(Native Method)
        at sun.misc.URLClassPath$JarLoader.ensureOpen(URLClassPath.java:614)
        at sun.misc.URLClassPath$JarLoader.<init>(URLClassPath.java:598)
        at sun.misc.URLClassPath$3.run(URLClassPath.java:348)
        at java.security.AccessController.doPrivileged(Native Method)
        at sun.misc.URLClassPath.getLoader(URLClassPath.java:337)
        at sun.misc.URLClassPath.getLoader(URLClassPath.java:314)
        at sun.misc.URLClassPath.getResource(URLClassPath.java:184)
        at java.net.URLClassLoader$1.run(URLClassLoader.java:209)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(URLClassLoader.java:205)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:321)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:266)
Caused by: java.lang.RuntimeException
        at sun.text.normalizer.NormalizerImpl.<clinit>(NormalizerImpl.java:61)
        ... 37 more

~


> There exists nothing like that then?  The patch looks ok now for me and
> you can push to move this thing forward finally.
> 
> However any more-direct reproducer from you or more explanations from
> jboss guys will be more appreciated.
> 
> btw - you must prepare patch for spec inclusion for this jira-big-patch
> because I do not believe there will be 1.11 release because of this.
> 
> Thanx and dont beat me for the questions :(
> J
>>
>>>
>>> After the explanation. Ok for... head and 1.11?
>>>
>>>
>>>
>>> J
>>
>

More information about the distro-pkg-dev mailing list