systemtap support with USTD1 only (Was: [PATCH 0 of 2] Add systemtap tapset tests)

[Andrew Hughes]

----- Original Message -----
> On Tue, 2012-03-27 at 18:28 -0400, Jon VanAlten wrote:
> > > And that is the attached patch. I got rid of USDT3 and just made
> > > GNU/Linux with systemtap USTD1 like Solaris with macros instead
> > > of
> > > functions for all DTRACE probes. All new tests PASS with this.
> > > 
> > > I think everything still left in systemtap.patch can be pushed
> > > into
> > > hotspot directly since the diff is actually pretty small. After
> > > this
> > > gets in icedtea7 HEAD I'll propose it there next.
> >
> > Sounds cool, but I am grossly unqualified to decide if this is
> > likely
> > to cause any issues.  Hopefully Andrew will have more to say :)
> 
> On irc Andrew said this looked fine, so I have pushed it.
> 

That's this Andrew... :-)

I was going to reply here too, just to say that I originally did the
most conservative changes to make sure everything worked, but I'm more
than happy for you to change things to whatever you think works best.
You maintain it, after all...

Getting this upstream would be good.  At the moment, this is conditional
in IcedTea rather than being just an always-applied patch in the forest.
Do you want to change this?  It would make sense to me, especially now
the upstream code has support for two DTrace implementations (Solaris
and Mac OS) rather than just one.  Conditional patches only tend to cause
pain if a build run doesn't test them.

> Thanks,
> 
> Mark
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07