Fwd: Re: ARM: Support for JVMTI notifications from JIT compiler on code generation

[Andrew Haley]

On 05/01/2012 02:51 PM, Andrew Dinn wrote:
> On 01/05/12 14:38, Andrew Haley wrote:
>> The patch is OK.
>>
>> I'm a little bit concerned that we're doing all this extra work and
>> allocating memory for JVMTI structures even when JVMTI isn't being
>> used, but I think that the overhead is small enough that it doesn't
>> matter.
> 
> Then perhaps one thing I should do is to enable a build time setting to
> disable notification of the JVMTI events and any associated work. I
> suggest adding
> 
>   #if !defined(DISABLE_THUMB2_JVMTI)
>   #define THUMB2_JVMTI
>   #endif
> 
> and then bracketing all the newly added code with
> 
>   #if THUMB2_JVMTI
>   . . .
>   #endif
> 
> That will leave JVMTI event generation compiled in by default but allow
> us to build a JVM with it compiled out if we ever want to come back and
> measure what effect it has.

I think that's OK, but I strongly suspect that option will never be used.

Andrew.