[rfc][icedtea-web] all debug outputs of unittests to stderr

Danesh Dadachanji ddadacha at redhat.com
Tue May 15 11:10:52 PDT 2012


Hi Jiri,

On 14/05/12 10:35 AM, Jiri Vanek wrote:
> I think that it is good idea to keep stdout of unittest clean, as there is stdout printed result. If you agree, then I will modify wiki
> with recommendation that all outputs should go to error stream.
>

Agreed, if it is not directly used, I think it should be stderr as well. It may look a bit weird that "New classloader: null" is going 
to stdout but there isn't much we can do about that.

> Currently few tests are printing to stdout. If you agree that it have sense, then there is patch which will move them to stderr.
> But I'm not 100% sure how excellent idea this is (maybe very non-sense rule?)
>
>
> 2012-05-14 Jiri Vanek <jvanek at redhat.com>
>
> * tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java:
> * tests/netx/unit/net/sourceforge/jnlp/cache/CacheLRUWrapperTest.java:
>     System.out replaced with System.err

There seems to be 2 spaces before System.out there, could you remove those? My only nitpick =)

Thanks for doing this! Feel free to push.

Cheers,
Danesh



More information about the distro-pkg-dev mailing list