[rfc] [icedtea-web] fix for PR811
Jiri Vanek
jvanek at redhat.com
Wed May 16 07:38:40 PDT 2012
This fix is taking care of correct encoding of urls and theirs proper caching (signing was not
affected AFAIK)
The fix itself is quite simple. Just calling URLecoder/encoder on proper place and is enchanced
urlcomapre to consider url==encoded(url) as true.
I must confess I dont like one thing - I'm handling "file" protocol differently(not encoding its
path) But I was not able to get rid of this :-/
It is making all spaces reproducers passing, and no regressions appeared.
I have added couple of new test which are torturing more the encoding/decoding. And testing my fix
also against applet and against signed version - because I have suspicion that signature may be
bounded with url. It looks like I was wrong or my testing self-certificate is not covering this
case (more probable)
changelogs:
fix:
2012-05-16 Jiri Vanek <jvanek at redhat.com>
Fixed behavior when encoded/characters needed encoding included in url
* NEWS: mentioned PR811
* netx/net/sourceforge/jnlp/cache/CacheUtil.java: (urlEquals) Enhanced
to be able compare encoded/decoded urls correctly.
(notNullUrlEquals) new method to separate comparing of individual parts of
url from null checks
* netx/net/sourceforge/jnlp/cache/ResourceTracker.java: (addResource)
is now encoding url if needed. (normalizeUrl) new method to encode path in
url of all except file protocol
tests:
2012-05-16 Jiri Vanek <jvanek at redhat.com>
More tests for Spaces and characters in urls
* netx/net/sourceforge/jnlp/cache/CacheLRUWrapper.java: and
* netx/net/sourceforge/jnlp/cache/CacheUtil.java: for unit-tests
purposes (cacheDir) make to point to tmp dir when no
DeploymentConfiguration exists.
* tests/jnlp_tests/signed/Spaces can be everywhere signed/:
couple of new test dooing the same as simple "Spaces can be everywhere"
but are signed
* tests/jnlp_tests/simple/Spaces can be everywhere/: added new test-cases
and html/jnlp test files to try more combinations of encodable characters
x launches
* tests/netx/unit/net/sourceforge/jnlp/cache/ResourceTrackerTest.java:
unittest for url encoder behavior
* tests/netx/unit/net/sourceforge/jnlp/cache/CacheUtilTest.java:
unittest for urlEquals function
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixed811-tests.diff
Type: text/x-patch
Size: 52770 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120516/b18da114/fixed811-tests.diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixed811-fix.diff
Type: text/x-patch
Size: 6102 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120516/b18da114/fixed811-fix.diff
More information about the distro-pkg-dev
mailing list