[RFC][icedtea-web] Do not allow searching of jar manifest classpath if jnlp_href is being used
Danesh Dadachanji
ddadacha at redhat.com
Wed May 16 15:58:07 PDT 2012
Hi,
Applets run by the plugin are allowed to specify classpaths in their jars' manifest files. IMO this is fine for applets run via
specifying a main class but this is not okay if they are run via jnlp_href. When using a JNLP via javaws, you do not have access to
manifest's classpaths. I believe this is a property of JNLP files. Therefore, since jnlp_href points to a JNLP file to do the guide the
launching and resource tracking, I propose we ignore classpaths when the plugin runs using jnlp_href.
To note, the proprietary plugin allows classpath specified jars but I do not think this is correct behaviour. FWIW I've run through all
the regression tests, none of them use this so far.
Is this okay to push to HEAD, 1.2 and 1.1?
+2012-05-16 Danesh Dadachanji <ddadacha at redhat.com>
+
+ Classpaths in jars' manifests are only considered when the applet is run
+ without using jnlp_href and a JNLP file.
+ * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java (activateJars):
+ Add conditional check for use of jnlp_href.
+
There are no differences in the patches between HEAD, 1.2 and 1.1 so I've only attached one.
Cheers,
Danesh
PS: this patch is dependent on this backport[1] going into 1.1.
[1] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-May/018533.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no-classpath-with-jnlp_href-HEAD-01.patch
Type: text/x-patch
Size: 1152 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120516/2380b758/no-classpath-with-jnlp_href-HEAD-01.patch
More information about the distro-pkg-dev
mailing list