Removal of two instances of synchronization on Boolean

[Deepak Bhole]

* Adam Domurad <adomurad at redhat.com> [2012-05-17 15:39]:
> Hello all. Tiny patch here to remove two instances of synchronization on
> Boolean (considered bad practice as typically only two Boolean objects
> exist).
> 
> While I was not entirely sure what should be done about the Boolean
> synchronization, Deepak's opinion was that the synchronization was not
> needed, so I submitted this small patch.

Hi Adam,

Right, I don't think synchronization is needed because the value is
modified only once. The second lock below locks just to read, and all it
does with the value is determine whether to print a stack trace.

OK for 1.1/1.2/HEAD from me, but a second review is advisable as I was
already in favor of this approach before posting.

Cheers,
Deepak

> 2012-05-17  Adam Domurad  <adomurad at redhat.com>
> 
>         * plugin/icedteanp/java/sun/applet/PluginStreamHandler.java:
> Removed 
>         unnecessary synchronization on Boolean (dangerous) for code that
> did
>         not require synchronization.

> diff --git a/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java b/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> --- a/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> +++ b/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> @@ -322,9 +322,7 @@
>              PluginDebug.debug("  PIPE: appletviewer read: ", message);
>  
>              if (message == null || message.equals("shutdown")) {
> -                synchronized (shuttingDown) {
> -                    shuttingDown = true;
> -                }
> +                shuttingDown = true;
>                  try {
>                      // Close input/output channels to plugin.
>                      pluginInputReader.close();
> @@ -362,10 +360,8 @@
>              } catch (IOException e) {
>                  // if we are shutting down, ignore write failures as 
>                  // pipe may have closed
> -                synchronized (shuttingDown) {
> -                    if (!shuttingDown) {
> -                        e.printStackTrace();
> -                    }
> +                if (!shuttingDown) {
> +                    e.printStackTrace();
>                  }
>  
>                  // either ways, if the pipe is broken, there is nothing