Removal of two instances of synchronization on Boolean

[Deepak Bhole]

* Adam Domurad <adomurad at redhat.com> [2012-05-17 16:30]:
> On Thu, 2012-05-17 at 15:48 -0400, Omair Majid wrote:
> > On 05/17/2012 03:38 PM, Adam Domurad wrote:
> > > Hello all. Tiny patch here to remove two instances of synchronization on
> > > Boolean (considered bad practice as typically only two Boolean objects
> > > exist).
> > > 
> > > While I was not entirely sure what should be done about the Boolean
> > > synchronization, Deepak's opinion was that the synchronization was not
> > > needed, so I submitted this small patch.
> > 
> > I could be wrong, but seems to me that read() and write() are running in
> > different threads. Without some form of synchronization, writes from one
> > thread may not be visible to the other thread at all. Making
> > shuttingDown a 'volatile boolean' should be sufficient.
> > 
> > Cheers,
> > Omair
> 
> 
> Thanks. The adjusted patch is attached. Also, for the subject of another
> patch I'm working on, does the comment at the top of the file suggest
> the class is named VoidPluginCallRequest or is it just me ?

Looks good to me! OK for 1.1/1.2/HEAD from me.

Thanks,
Deepak

> diff --git a/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java b/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> --- a/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> +++ b/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> @@ -59,7 +59,7 @@
>      private JavaConsole console = new JavaConsole();
>  
>      private PluginMessageConsumer consumer;
> -    private Boolean shuttingDown = false;
> +    private volatile boolean shuttingDown = false;
>  
>  
>      public PluginStreamHandler(InputStream inputstream, OutputStream outputstream)
> @@ -322,9 +322,7 @@
>              PluginDebug.debug("  PIPE: appletviewer read: ", message);
>  
>              if (message == null || message.equals("shutdown")) {
> -                synchronized (shuttingDown) {
> -                    shuttingDown = true;
> -                }
> +                shuttingDown = true;
>                  try {
>                      // Close input/output channels to plugin.
>                      pluginInputReader.close();
> @@ -362,10 +360,8 @@
>              } catch (IOException e) {
>                  // if we are shutting down, ignore write failures as 
>                  // pipe may have closed
> -                synchronized (shuttingDown) {
> -                    if (!shuttingDown) {
> -                        e.printStackTrace();
> -                    }
> +                if (!shuttingDown) {
> +                    e.printStackTrace();
>                  }
>  
>                  // either ways, if the pipe is broken, there is nothing