[RFC][icedtea-web] Small code cleanup changes: fixing some code cloning, misleading comments & parameters etc

[Adam Domurad]

Hi all. This incorporates some changes I made to reduce code cloning on a patch that I have to reconsider partially, as well as some comment clean ups etc. Generally contains small code cleanup changes, fixing some code cloning, misleading comments & parameters etc

Changelog:
2012-05-17  Adam Domurad  <adomurad at redhat.com>
        Code cleanup, unification of cloned code & comment fixing
        * netx/net/sourceforge/jnlp/browser/BrowserAwareProxySelector.java:
        Added break statements (good practice, here it wouldn't affect the code
        due to a check of == null before changing the value).
        * netx/net/sourceforge/jnlp/cache/UpdatePolicy.java:
        Made fields intended as constants 'final'
        * netx/net/sourceforge/jnlp/controlpanel/CachePane.java:
        generateData(DirectoryNode root) had useless parameter - was set before
        being used. Similarly, the 'root' member variable was never set. Made
        the 'root' member variable set instead and passed to generateData.   
        * netx/net/sourceforge/jnlp/security/viewer/CertificatePane.java:
        Reduced cloning of code by introducing two methods,
        initializeCertificateTable(table) and 
        createCertificateScrollPane(table)
        * plugin/icedteanp/java/sun/applet/JavaConsole.java:
        Fixed a usage of == where .equals is more appropriate
        * plugin/icedteanp/java/sun/applet/AppletSecurityContextManager.java:
        Comment at top implies class is named VoidPluginCallRequest, with 
        description cloned from that class. Added proper class name with TODO
        for someone better fit to describe the class.
        * plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java: Same
        * plugin/icedteanp/java/sun/applet/PluginClassLoader.java: Same
        * plugin/icedteanp/java/sun/applet/PluginDebug.java: Same
        * plugin/icedteanp/java/sun/applet/PluginException.java: Same
        * plugin/icedteanp/java/sun/applet/PluginMain.java: Same
        * plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java: Same
        * plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java: 
        Same
        * plugin/icedteanp/java/sun/applet/PluginStreamHandler.java: Same
        * plugin/icedteanp/java/sun/applet/RequestQueue.java: Same
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch4.patch
Type: text/x-patch
Size: 11460 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120517/0667f97d/patch4.patch