/hg/icedtea-web: Removal of synchronization on Boolean in Plugin...

[adomurad at icedtea.classpath.org]

changeset b67e12ff7837 in /hg/icedtea-web
details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=b67e12ff7837
author: Adam Domurad <adomurad at redhat.com>
date: Fri May 18 09:27:24 2012 -0400

	Removal of synchronization on Boolean in PluginStreamHandler.
	Synchronization on Boolean is dangerous and was unnecessary in this context.
	As well, the Boolean flag that was being used during shut down was changed
	to a volatile boolean so changes could be seen without synchronization.


diffstat:

 plugin/icedteanp/java/sun/applet/PluginStreamHandler.java |  12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diffs (36 lines):

diff -r 7151720a2f5b -r b67e12ff7837 plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
--- a/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java	Thu May 17 14:14:03 2012 -0400
+++ b/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java	Fri May 18 09:27:24 2012 -0400
@@ -59,7 +59,7 @@
     private JavaConsole console = new JavaConsole();
 
     private PluginMessageConsumer consumer;
-    private Boolean shuttingDown = false;
+    private volatile boolean shuttingDown = false;
 
 
     public PluginStreamHandler(InputStream inputstream, OutputStream outputstream)
@@ -322,9 +322,7 @@
             PluginDebug.debug("  PIPE: appletviewer read: ", message);
 
             if (message == null || message.equals("shutdown")) {
-                synchronized (shuttingDown) {
-                    shuttingDown = true;
-                }
+                shuttingDown = true;
                 try {
                     // Close input/output channels to plugin.
                     pluginInputReader.close();
@@ -362,10 +360,8 @@
             } catch (IOException e) {
                 // if we are shutting down, ignore write failures as 
                 // pipe may have closed
-                synchronized (shuttingDown) {
-                    if (!shuttingDown) {
-                        e.printStackTrace();
-                    }
+                if (!shuttingDown) {
+                    e.printStackTrace();
                 }
 
                 // either ways, if the pipe is broken, there is nothing