[rfc][icedtea-web] improvements to reproducers engine
Jiri Vanek
jvanek at redhat.com
Sun May 20 07:18:19 PDT 2012
Hi!
During last week I was asked by Danesh and Saad to introduce more hierarchical server and whitelist for reproducers.
The following patches should add those features. Can you guys (requesters:) mind to review if they match yours needs?
During the writing i found one bug in current implementation - redundant quotes. I fixed this in third changeset.
Zipped attachment is example of source and result.
*smallEnchancemtnsToreproducers-jarsInDirs.diff*
I have come many times to issue that I needed jars in more complex directory structure. After speaking with Danesh i come with idea of package-like (but reverse) approach.
If the directory with reproducer will be named something.in.time then in jnlp_testserver will be saved as something/in/time.jar.
- original something.in.time.jar as created now will remain persisted
- testcases (definieetly) and resources (I can imagine need to have resource in upper dir) are not affected by this change
- see the example of source and resutl :)
2012-05-20 Jiri Vanek <jvanek at redhat.com>
Reproducers engine enhanced for jars in subdirectories by "." naming convention
* Makefile.am: (stamps/change-dots-to-paths.stamp) new target to copy jars
with dots (.jar omitted) to the java-like package/directory structure in
jnlp_test_server
(EXPORTED_TEST_CERT) now depends on stamps/change-dots-to-paths.stamp
(clean-netx-dist-tests) removes stamps/change-dots-to-paths.stamp too.
*smallEnchancemtnsToreproducers-whiteList.diff*
This is very simple simplke implementation ow whitelist. It is mentioned for developing purposes. If developer
is working on set of reproducer and want to tests them, then he just select them by regexes inside this new file.
Although it is very simpl echnage I found it very useful.
2012-05-20 Jiri Vanek <jvanek at redhat.com>
Introduced whitelist for reproducers
* netx-dist-tests-whitelist: new file, contains regular expressions
(separated by space) for expr to select testcases which only will be
run. By default set to all by expression .*
* Makefile.am: (REPRODUCERS_CLASS_NAMES) When class with testcases is
going to be included in list, it is at first check for match in whitelist.
If there is no match, will not be included.
*smallEnchancemtnsToreproducers-minorFix.diff:*
this ifix is much smaller then it looks like. It actually only removes quotes (which added \n and so wrong interpretation of paths)
cp -R --parents "$$notSrcFiles" "$(JNLP_TESTS_DIR)/$$dir/" ; \ -> cp -R --parents $$notSrcFiles "$(JNLP_TESTS_DIR)/$$dir/" ; \ and
add test for src directory. The rest is indentation. This changeset should go in in any case.
2012-05-20 Jiri Vanek <jvanek at redhat.com>
Fixed error in reproducers source preparation
* Makefile.am: (stamps/netx-dist-tests-prepare-reproducers.stamp) removed
inappropriately used quotes when copying notSrcFiles. Sucre files now
copied only if src dir exists in reproducer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smallEnchancemtnsToreproducers-jarsInDirs.diff
Type: text/x-patch
Size: 2085 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120520/127b2798/smallEnchancemtnsToreproducers-jarsInDirs.diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smallEnchancemtnsToreproducers-minorFix.diff
Type: text/x-patch
Size: 2063 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120520/127b2798/smallEnchancemtnsToreproducers-minorFix.diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smallEnchancemtnsToreproducers-whiteList.diff
Type: text/x-patch
Size: 1724 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120520/127b2798/smallEnchancemtnsToreproducers-whiteList.diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-web-whitelist-fix-directories.tar.gz
Type: application/x-gzip
Size: 4746 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120520/127b2798/icedtea-web-whitelist-fix-directories.tar.gz
More information about the distro-pkg-dev
mailing list