icedtea7-2.1 - fails to build with gcc4.7

[Andrew Haley]

On 05/21/2012 04:20 PM, Andrew Hughes wrote:
> ----- Original Message -----
>> I've tried also latest hg-shot from 2.1 branch fails in ArchLinux:
>>
>> g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I.
>> -I/build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/prims
>> -I/build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm
>> -I/build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/cpu/x86/vm
>> -I/build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/os_cpu/linux_x86/vm
>> -I/build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/os/linux/vm
>> -I/build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/os/posix/vm
>> -I../generated -DHOTSPOT_RELEASE_VERSION="\"22.0-b10\""
>> -DHOTSPOT_BUILD_TARGET="\"product\""
>> -DHOTSPOT_BUILD_USER="\"nobody\"" -DHOTSPOT_LIB_ARCH=\"amd64\"
>> -DJRE_RELEASE_VERSION="\"1.7.0_03-b147\""
>> -DHOTSPOT_VM_DISTRO="\"OpenJDK\"" -DDERIVATIVE_ID="\"IcedTea7
>> 2.1.1pre\"" -DDISTRIBUTION_ID="\"Custom build (Sun May 20 15:47:41
>> UTC 2012)\"" -march=x86-64 -mtune=generic -O2 -pipe
>> -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2
>> -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86
>>  _64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64
>>  -DTARGET_COMPILER_gcc -DCOMPILER2 -DCOMPILER1  -fno-rtti
>>  -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=hidden -m64
>>  -pipe -g -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86
>>  -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86
>>  -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc
>>  -DCOMPILER2 -DCOMPILER1 -fpic -fno-rtti -fno-exceptions
>>  -D_REENTRANT -fcheck-new -fvisibility=hidden -m64 -pipe -g -O3
>>  -fno-strict-aliasing -g -DVM_LITTLE_ENDIAN -D_LP64=1
>>  -fno-omit-frame-pointer -Werror -Wpointer-arith -Wsign-compare
>>     -c -MMD -MP -MF ../generated/dependencies/g1BlockOffsetTable.o.d
>>  -o g1BlockOffsetTable.o
>>  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp
>> In file included from /usr/include/string.h:642:0,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/utilities/globalDefinitions_gcc.hpp:35,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/utilities/globalDefinitions.hpp:29,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/utilities/debug.hpp:29,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/runtime/globals.hpp:28,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/memory/allocation.hpp:28,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/memory/iterator.hpp:28,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/memory/genOopClosures.hpp:28,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/oops/klass.hpp:28,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/runtime/handles.hpp:28,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/code/oopRecorder.hpp:28,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/asm/assembler.hpp:28,
>>                  from
>>                  /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/precompiled.hpp:29:
>> In function 'void* memset(void*, int, size_t)',
>>     inlined from 'void
>>     G1BlockOffsetSharedArray::_ZN24G1BlockOffsetSharedArray16set_offset_arrayEmmh.isra.72(unsigned
>>     char*, size_t, size_t, unsigned char)' at
>>     /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.hpp:169:52,
>>     inlined from 'void
>>     G1BlockOffsetArray::set_remainder_to_point_to_start_incl(size_t,
>>     size_t)' at
>>     /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp:195:67,
>>     inlined from 'void
>>     G1BlockOffsetArray::_ZN18G1BlockOffsetArray31set_remainder_to_point_to_startEP8HeapWordS1_.part.81(HeapWord*,
>>     HeapWord*)' at
>>     /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp:168:61,
>>     inlined from 'void
>>     G1BlockOffsetArray::set_remainder_to_point_to_start(HeapWord*,
>>     HeapWord*)' at
>>     /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp:369:1,
>>     inlined from 'void
>>     G1BlockOffsetArray::alloc_block_work2(HeapWord**, size_t*,
>>     HeapWord*, HeapWord*)' at
>>     /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp:510:53,
>>     inlined from 'HeapWord*
>>     G1BlockOffsetArray::forward_to_block_containing_addr_slow(HeapWord*,
>>     HeapWord*, const void*)' at
>>     /build/src/icedtea7-2-1-ae30f070f936/openjdk/hotspot/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp:394:59:
>> /usr/include/bits/string3.h:82:32: error: call to
>> '__warn_memset_zero_len' declared with attribute warning: memset
>> used with constant zero length parameter; this could be due to
>> transposed parameters [-Werror]
>> /usr/include/bits/string3.h:82:32: error: call to
>> '__warn_memset_zero_len' declared with attribute warning: memset
>> used with constant zero length parameter; this could be due to
>> transposed parameters [-Werror]
>> /usr/include/bits/string3.h:82:32: error: call to
>> '__warn_memset_zero_len' declared with attribute warning: memset
>> used with constant zero length parameter; this could be due to
>> transposed parameters [-Werror]
>> /usr/include/bits/string3.h:82:32: error: call to
>> '__warn_memset_zero_len' declared with attribute warning: memset
>> used with constant zero length parameter; this could be due to
>> transposed parameters [-Werror]
>> /usr/include/bits/string3.h:82:32: error: call to
>> '__warn_memset_zero_len' declared with attribute warning: memset
>> used with constant zero length parameter; this could be due to
>> transposed parameters [-Werror]
>> /usr/include/bits/string3.h:82:32: error: call to
>> '__warn_memset_zero_len' declared with attribute warning: memset
>> used with constant zero length parameter; this could be due to
>> transposed parameters [-Werror]
>> cc1plus: all warnings being treated as errors
>> make[7]: *** [g1BlockOffsetTable.o] Error 1
>>
>> gcc-Version 4.7.0 20120505 (prerelease) (GCC)
>>
>> What gcc fix am I missing?
> 
> I don't know.  It works for me with post-release gcc:
> 
> gcc (Gentoo 4.7.0_pre9999) 4.7.0-pre9999 20120501 (prerelease) commit 2ccc543c3a80587949eba6f918680e63031954bc
> 
> What architecture are you on?

It's x86_64.

GCC has discovered, by doing some amazingly deep inlining, that
memset() is being passed zero as a length arg and a variable as the
fill byte.  I can't immediately tell if this is a bug, but it's not
obviously one.  The extent to which GCC inlines is variable and based
on a bunch of heuristics, so I'm not surprised it doesn't always
trigger.

Andrew.