[rfc] [icedtea-web] make links

Jiri Vanek jvanek at redhat.com
Mon May 21 09:10:23 PDT 2012


On 05/21/2012 04:38 PM, Andrew Hughes wrote:
> ----- Original Message -----
>> * Jiri Vanek<jvanek at redhat.com>  [2012-05-18 05:07]:
>>> On 05/17/2012 09:42 PM, Deepak Bhole wrote:
>> ...
>> ...
>>>>
>>>> What if something goes wrong during testing and it exits before
>>>> unlinking? The user system would be set to use the wrong plugin --
>>>> worse
>>>> yet, it could be without the user's knowledge.
>>>
>>> agree - but form this point of view I'm doing the best thing right
>>> now.
>>>
>>> make
>>> make check
>>> make install
>>> make links //must be run manually
>>> make run-netx-dist-tests  //if  links point to something not
>>> installed by this make install, then there is tests to catch this.
>>> If there are no correct links all browser tests will fail
>>> make unlink (or make clean) //make unlink *restores* previous
>>> configuration
>>>
>>
>> Ah, so something common like make test will never accidentally run
>> it.
>>
>> Okay, then I have no objections to this approach.
>>
>
> Now this isn't linked to the main "make check" cycle, I see no harm
> in putting this in.

Thanx both of you for sharing your minds! Pushed to head.
>
> But this underlying issue of not being able to test without installing needs
> fixing.  Please file a bug for it.

bug 984 created (probably for myself...)


J




More information about the distro-pkg-dev mailing list