[fyi] [icedtea-web] Fixed security tests to pass both jdk6 and 7

Jiri Vanek jvanek at redhat.com
Tue May 22 04:38:54 PDT 2012


On 05/22/2012 01:34 PM, Pavel Tisnovsky wrote:
> Hi Jiri,
>
> you changes looks correct but as a QE I would be more happy if this check
> would be "splitted" into two variants (two asserts) according to the
> JRE used. We use following technique in Mauve tests:

hmhmh. This can be very useful, but not in this case. Danesh have found this difference also between 
6' releases (see the thread in original email).

I will keep it in mind in case that any other issues will apepar because of new jdk release.

Thanx for hint!

J.
>
>    private static int JDKVersion()
>    {
>      String[] javaVersion = System.getProperty("java.version").split("\\.");
>      return Integer.parseInt(javaVersion[1]);
>    }
>
> Cheers,
> Pavel
>
> Jiri Vanek wrote:
>> Hi!
>>
>> As I mentioned yesterday on java team the test are failing on openjdk7
>> because of changed exception message. This patch is fixing it.
>> This was already spotted once and I used the solution reviewed by Danesh
>> (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-March/017540.html
>> thread)
>> Test are now passing  both jdk.
>>
>>
>> 2012-05-22  Jiri Vanek<jvanek at redhat.com>
>>
>>      *
>> tests/jnlp_tests/signed/ReadPropertiesSigned/testcases/ReadPropertiesSignedTest.java:
>>
>>      *
>> tests/jnlp_tests/simple/AddShutdownHook/testcases/AddShutdownHookTest.java:
>>      *
>> tests/jnlp_tests/simple/AllStackTraces/testcases/AllStackTracesTest.java:
>>      *
>> tests/jnlp_tests/simple/CreateClassLoader/testcases/CreateClassLoaderTest.java:
>>
>>      *
>> tests/jnlp_tests/simple/ReadEnvironment/testcases/ReadEnvironmentTest.java:
>>      *
>> tests/jnlp_tests/simple/ReadProperties/testcases/ReadPropertiesTest.java:
>>      *
>> tests/jnlp_tests/simple/RedirectStreams/testcases/RedirectStreamsTest.java:
>>      *
>> tests/jnlp_tests/simple/ReplaceSecurityManager/testcases/ReplaceSecurityManagerTest.java:
>>
>>      *
>> tests/jnlp_tests/simple/SetContextClassLoader/testcases/SetContextClassLoaderTest.java:
>>
>>      All exact matches upon AccessControlException replaced by regular
>> expression matching both jdk7 and jdk6 syntax
>>
>




More information about the distro-pkg-dev mailing list