[fyi] [icedtea-web] Fixed security tests to pass both jdk6 and 7

[Jiri Vanek]

On 05/22/2012 02:11 PM, Jiri Vanek wrote:
> On 05/22/2012 01:58 PM, Pavel Tisnovsky wrote:
>> Jiri Vanek wrote:
>>> On 05/22/2012 01:34 PM, Pavel Tisnovsky wrote:
>>>> Hi Jiri,
>>>>
>>>> you changes looks correct but as a QE I would be more happy if this check
>>>> would be "splitted" into two variants (two asserts) according to the
>>>> JRE used. We use following technique in Mauve tests:
>>>
>>> hmhmh. This can be very useful, but not in this case. Danesh have found
>>> this difference also between 6' releases (see the thread in original
>>> email).
>>
>> It's interesting that there's a difference in exception message in case of JDK6
>> but in fact it's not specified precisely in API doc.
>>
>> Then I'm ok with your solution ;-)
>>
>> Cheers,
>> Pavel
>>
>>>
> Argh. I have just realized that I have used .* also where too strong!
> There is fixed version (replacing inner .* by .{0,5}. Tested both on f16/f17. Can you please verify
> I did not mess more stuff? Changelog will remain same.
>

tahnx. Pushed to head.

Can I backport it also to 1.2?

> Thanx again for review!
>    J.
>>> I will keep it in mind in case that any other issues will apepar because
>>> of new jdk release.
>>>
>>> Thanx for hint!
>>>
>>> J.
>>>>
>>>>     private static int JDKVersion()
>>>>     {
>>>>       String[] javaVersion =
>>>> System.getProperty("java.version").split("\\.");
>>>>       return Integer.parseInt(javaVersion[1]);
>>>>     }
>>>>
>>>> Cheers,
>>>> Pavel
>>>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixedReproducersForJdk7-1.2.1.diff
Type: text/x-patch
Size: 15482 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120522/634d9179/fixedReproducersForJdk7-1.2.1.diff