[icedtea-web][RFC] sprintf -> snprintf in icedtea-web plugin, C++-side

[Deepak Bhole]

* Adam Domurad <adomurad at redhat.com> [2012-05-22 11:51]:
> Hello all. Small patch, description in ChangeLog. I ran it against run-netx-dist-tests with no regressions.
> The motivation being that sprintf is generally to be avoided, because if something goes wrong somewhere, it's better to have an extra fallback that prevents buffer overflow.
> 
> A few small buffers that were being malloc/free'd in a very short period of time were made to be stack based. 
> There isn't a terrible need to change it performance wise, it does however make for clearer code with less possibility of error (eg, free being left out).
> 
> Small note: 
> snprintf is -technically- non-standard C++ (C99 standard). However, as long as GCC is targetted, there is no issue -and- it was already used in the source as it were.
>

Hi Adam,

One minor nit-pick:

> -
> -    result->append(str);
> -    free(str);
> +    if (largestr != NULL){
> +    	result->append(largestr);
> +    	free(largestr);
> +    } else {
> +    	result->append(str);
> +    }

Please change the above to be indented with 2 spaces instead of 1. I
know the file is mixed, but for the most part it does use 2-space
indentation.

Everything else looks good. I agree that snprintf is better -- good
catch.

Ok for HEAD.

Cheers,
Deepak